Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2612713002: Move core/editing timer to frame-specific task runners. (Closed)

Created:
3 years, 11 months ago by dcheng
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, groby+blinkspell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move core/editing timer to frame-specific task runners. Caret blinking is an internal feature, so move it to the unpecced timer task queue for now. In the future, this may change to be driven by BeginFrame updates. Similarly, spellcheck is also an internal feature of Chromium, so it also uses the unspecced timer task queue. BUG=624694 Committed: https://crrev.com/43d4fc6b461e78656252368aa7d042c019df40f6 Cr-Commit-Position: refs/heads/master@{#441390}

Patch Set 1 #

Messages

Total messages: 14 (9 generated)
dcheng
Fairly straightforward: I made a few plumbing changes, since the LocalFrame argument is never null.
3 years, 11 months ago (2017-01-04 04:23:09 UTC) #2
haraken
LGTM
3 years, 11 months ago (2017-01-04 11:45:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612713002/1
3 years, 11 months ago (2017-01-04 16:32:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 16:36:33 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 16:38:49 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43d4fc6b461e78656252368aa7d042c019df40f6
Cr-Commit-Position: refs/heads/master@{#441390}

Powered by Google App Engine
This is Rietveld 408576698