third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp - Issue 2612713002: Move core/editing timer to frame-specific task runners.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp

Issue 2612713002: Move core/editing timer to frame-specific task runners. (Closed)

Patch Set: Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.h ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp b/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp

index 6e5195e3d96dea6e22b63fc8735a2f761bb39045..7230ffffd5ee867855661bf9b1c5572e84496107 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp

+++ b/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp

@@ -5,6 +5,7 @@

#include "core/editing/spellcheck/IdleSpellCheckCallback.h"

#include "core/dom/IdleRequestOptions.h"

+#include "core/dom/TaskRunnerHelper.h"

#include "core/editing/EditingUtilities.h"

#include "core/editing/FrameSelection.h"

#include "core/editing/VisibleSelection.h"

@@ -47,7 +48,9 @@ IdleSpellCheckCallback* IdleSpellCheckCallback::create(LocalFrame& frame) {

IdleSpellCheckCallback::IdleSpellCheckCallback(LocalFrame& frame)

: m_state(State::kInactive),

m_frame(frame),

- m_coldModeTimer(this, &IdleSpellCheckCallback::coldModeTimerFired) {}

+ m_coldModeTimer(TaskRunnerHelper::get(TaskType::UnspecedTimer, &frame),

+ this,

+ &IdleSpellCheckCallback::coldModeTimerFired) {}

SpellCheckRequester& IdleSpellCheckCallback::spellCheckRequester() const {

// TODO(xiaochengh): decouple with SpellChecker after SpellCheckRequester is