Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: third_party/WebKit/Source/core/editing/FrameCaret.cpp

Issue 2612713002: Move core/editing timer to frame-specific task runners. (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameCaret.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameCaret.cpp b/third_party/WebKit/Source/core/editing/FrameCaret.cpp
index 7efa3856c33c9a9d7ea1fcba430a669f98ed3c3f..85fc98a621c6e3dc470834d6dc509655305b7973 100644
--- a/third_party/WebKit/Source/core/editing/FrameCaret.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameCaret.cpp
@@ -25,6 +25,7 @@
#include "core/editing/FrameCaret.h"
+#include "core/dom/TaskRunnerHelper.h"
#include "core/editing/EditingUtilities.h"
#include "core/editing/Editor.h"
#include "core/editing/SelectionEditor.h"
@@ -41,19 +42,19 @@
namespace blink {
-FrameCaret::FrameCaret(LocalFrame* frame,
+FrameCaret::FrameCaret(LocalFrame& frame,
const SelectionEditor& selectionEditor)
: m_selectionEditor(&selectionEditor),
m_frame(frame),
m_caretVisibility(CaretVisibility::Hidden),
m_previousCaretVisibility(CaretVisibility::Hidden),
- m_caretBlinkTimer(this, &FrameCaret::caretBlinkTimerFired),
+ m_caretBlinkTimer(TaskRunnerHelper::get(TaskType::UnspecedTimer, &frame),
+ this,
+ &FrameCaret::caretBlinkTimerFired),
m_caretRectDirty(true),
m_shouldPaintCaret(true),
m_isCaretBlinkingSuspended(false),
- m_shouldShowBlockCursor(false) {
- DCHECK(frame);
-}
+ m_shouldShowBlockCursor(false) {}
FrameCaret::~FrameCaret() = default;
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameCaret.h ('k') | third_party/WebKit/Source/core/editing/FrameSelection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698