Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: third_party/WebKit/Source/core/editing/FrameCaret.h

Issue 2612713002: Move core/editing timer to frame-specific task runners. (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameCaret.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/FrameCaret.h
diff --git a/third_party/WebKit/Source/core/editing/FrameCaret.h b/third_party/WebKit/Source/core/editing/FrameCaret.h
index e775097708ff95dff216491b5eeb68ac931789ea..6da45f284cc29f09678b52fe1475ebdfb809faa7 100644
--- a/third_party/WebKit/Source/core/editing/FrameCaret.h
+++ b/third_party/WebKit/Source/core/editing/FrameCaret.h
@@ -38,7 +38,7 @@ enum class CaretVisibility { Visible, Hidden };
class CORE_EXPORT FrameCaret final : public CaretBase {
public:
- FrameCaret(LocalFrame*, const SelectionEditor&);
+ FrameCaret(LocalFrame&, const SelectionEditor&);
~FrameCaret() override;
bool isActive() const { return caretPosition().isNotNull(); }
@@ -95,7 +95,8 @@ class CORE_EXPORT FrameCaret final : public CaretBase {
LayoutRect m_previousCaretRect;
CaretVisibility m_caretVisibility;
CaretVisibility m_previousCaretVisibility;
- Timer<FrameCaret> m_caretBlinkTimer;
+ // TODO(https://crbug.com/668758): Consider using BeginFrame update for this.
+ TaskRunnerTimer<FrameCaret> m_caretBlinkTimer;
bool m_caretRectDirty : 1;
bool m_shouldPaintCaret : 1;
bool m_isCaretBlinkingSuspended : 1;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameCaret.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698