Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2612283002: Fix confusing naming re physical/dip bounds in vr_shell.cc (Closed)

Created:
3 years, 11 months ago by mthiesse
Modified:
3 years, 11 months ago
Reviewers:
boliu
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix confusing naming re physical/dip bounds in vr_shell.cc VrShell::ContentBoundsChanged was in physical pixels, while VrShellGl::ContentBoundsChanged was in dip. BUG= Review-Url: https://codereview.chromium.org/2612283002 Cr-Commit-Position: refs/heads/master@{#441709} Committed: https://chromium.googlesource.com/chromium/src/+/e3dcf05a7ca40e97ec9535762be7f472c9e11e37

Patch Set 1 #

Total comments: 2

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 1 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mthiesse
PTAL
3 years, 11 months ago (2017-01-05 17:17:52 UTC) #3
boliu
lgtm https://codereview.chromium.org/2612283002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2612283002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc#newcode347 chrome/browser/android/vr_shell/vr_shell.cc:347: TRACE_EVENT0("gpu", "VrShell::ContentBoundsChanged"); update trace event name too?
3 years, 11 months ago (2017-01-05 17:28:42 UTC) #4
mthiesse
https://codereview.chromium.org/2612283002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc File chrome/browser/android/vr_shell/vr_shell.cc (right): https://codereview.chromium.org/2612283002/diff/1/chrome/browser/android/vr_shell/vr_shell.cc#newcode347 chrome/browser/android/vr_shell/vr_shell.cc:347: TRACE_EVENT0("gpu", "VrShell::ContentBoundsChanged"); On 2017/01/05 17:28:42, boliu wrote: > update ...
3 years, 11 months ago (2017-01-05 18:06:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612283002/20001
3 years, 11 months ago (2017-01-05 18:06:50 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 18:39:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e3dcf05a7ca40e97ec9535762be7...

Powered by Google App Engine
This is Rietveld 408576698