chrome/browser/android/vr_shell/vr_shell.h - Issue 2612283002: Fix confusing naming re physical/dip bounds in vr_shell.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/vr_shell.h

Issue 2612283002: Fix confusing naming re physical/dip bounds in vr_shell.cc (Closed)

Patch Set: oops Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/vr_shell/vr_shell.h

diff --git a/chrome/browser/android/vr_shell/vr_shell.h b/chrome/browser/android/vr_shell/vr_shell.h

index a95676ea6ce6316c07baf9a73a2cf074ca4cf434..435ef38182bb96a0144335ab42e82d8d85c25da3 100644

--- a/chrome/browser/android/vr_shell/vr_shell.h

+++ b/chrome/browser/android/vr_shell/vr_shell.h

@@ -111,12 +111,12 @@ class VrShell : public device::GvrDelegate, content::WebContentsObserver {

void GvrDelegateReady();

void AppButtonPressed();

- void ContentBoundsChanged(

+ void ContentPhysicalBoundsChanged(

JNIEnv* env,

const base::android::JavaParamRef<jobject>& object,

jint width, jint height, jfloat dpr);

- void UIBoundsChanged(

+ void UIPhysicalBoundsChanged(

JNIEnv* env,

const base::android::JavaParamRef<jobject>& object,

jint width, jint height, jfloat dpr);