Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4006)

Unified Diff: chrome/browser/android/vr_shell/vr_shell.cc

Issue 2612283002: Fix confusing naming re physical/dip bounds in vr_shell.cc (Closed)
Patch Set: oops Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/vr_shell/vr_shell.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/vr_shell.cc
diff --git a/chrome/browser/android/vr_shell/vr_shell.cc b/chrome/browser/android/vr_shell/vr_shell.cc
index ee4aa9843e6188d468b450677340af9e5b586d8b..e944dd27259e0c253568930d95d4f2bd07175a8a 100644
--- a/chrome/browser/android/vr_shell/vr_shell.cc
+++ b/chrome/browser/android/vr_shell/vr_shell.cc
@@ -340,19 +340,20 @@ void VrShell::AppButtonPressed() {
#endif
}
-void VrShell::ContentBoundsChanged(JNIEnv* env,
- const JavaParamRef<jobject>& object,
- jint width, jint height, jfloat dpr) {
- TRACE_EVENT0("gpu", "VrShell::ContentBoundsChanged");
+void VrShell::ContentPhysicalBoundsChanged(JNIEnv* env,
+ const JavaParamRef<jobject>& object,
+ jint width, jint height,
+ jfloat dpr) {
+ TRACE_EVENT0("gpu", "VrShell::ContentPhysicalBoundsChanged");
GLThread* thread = static_cast<GLThread*>(gl_thread_.get());
PostToGlThreadWhenReady(base::Bind(&VrShellGl::ContentPhysicalBoundsChanged,
thread->GetVrShellGl(), width, height));
content_compositor_->SetWindowBounds(gfx::Size(width, height));
}
-void VrShell::UIBoundsChanged(JNIEnv* env,
- const JavaParamRef<jobject>& object,
- jint width, jint height, jfloat dpr) {
+void VrShell::UIPhysicalBoundsChanged(JNIEnv* env,
+ const JavaParamRef<jobject>& object,
+ jint width, jint height, jfloat dpr) {
GLThread* thread = static_cast<GLThread*>(gl_thread_.get());
PostToGlThreadWhenReady(base::Bind(&VrShellGl::UIPhysicalBoundsChanged,
thread->GetVrShellGl(), width, height));
« no previous file with comments | « chrome/browser/android/vr_shell/vr_shell.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698