Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4290)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Issue 2612283002: Fix confusing naming re physical/dip bounds in vr_shell.cc (Closed)
Patch Set: oops Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/vr_shell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
index 3bdbb7277dbfd37b107a0d578a55294a664af351..47d59652794c7580512ef3572ba321554d334c34 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
@@ -188,7 +188,7 @@ public class VrShellImpl extends GvrLayout implements VrShell, SurfaceHolder.Cal
mUiVirtualDisplay.update(size, size, dpr, null, null, null);
mUiCVC.onSizeChanged(surfaceWidth, surfaceHeight, 0, 0);
getViewRoot(mUiCVC).onPhysicalBackingSizeChanged(surfaceWidth, surfaceHeight);
- nativeUIBoundsChanged(mNativeVrShell, surfaceWidth, surfaceHeight, dpr);
+ nativeUIPhysicalBoundsChanged(mNativeVrShell, surfaceWidth, surfaceHeight, dpr);
}
@CalledByNative
@@ -201,7 +201,7 @@ public class VrShellImpl extends GvrLayout implements VrShell, SurfaceHolder.Cal
mContentVirtualDisplay.update(size, size, dpr, null, null, null);
mContentCVC.onSizeChanged(surfaceWidth, surfaceHeight, 0, 0);
getViewRoot(mContentCVC).onPhysicalBackingSizeChanged(surfaceWidth, surfaceHeight);
- nativeContentBoundsChanged(mNativeVrShell, surfaceWidth, surfaceHeight, dpr);
+ nativeContentPhysicalBoundsChanged(mNativeVrShell, surfaceWidth, surfaceHeight, dpr);
}
private ViewRoot getViewRoot(ContentViewCore cvc) {
@@ -320,8 +320,9 @@ public class VrShellImpl extends GvrLayout implements VrShell, SurfaceHolder.Cal
private native void nativeOnTriggerEvent(long nativeVrShell);
private native void nativeOnPause(long nativeVrShell);
private native void nativeOnResume(long nativeVrShell);
- private native void nativeContentBoundsChanged(long nativeVrShell, int width, int height,
+ private native void nativeContentPhysicalBoundsChanged(long nativeVrShell, int width,
+ int height, float dpr);
+ private native void nativeUIPhysicalBoundsChanged(long nativeVrShell, int width, int height,
float dpr);
- private native void nativeUIBoundsChanged(long nativeVrShell, int width, int height, float dpr);
private native void nativeSetWebVrMode(long nativeVrShell, boolean enabled);
}
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/vr_shell.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698