Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2610763002: [Predator] Pass flags to callstack detector and fix nit. (Closed)

Created:
3 years, 11 months ago by Sharu Jiang
Modified:
3 years, 11 months ago
Reviewers:
wrengr, stgao
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Martin Barbella, inferno
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Predator] Pass flags to callstack detector and fix nit. A minor bug fixing - passing flags to callstack detector in cluterfuzz parser Fix a remaining nit. BUG=605360 TBR=stgao@chromium.org Review-Url: https://codereview.chromium.org/2610763002 Committed: https://chromium.googlesource.com/infra/infra/+/dcecde7f28e429a1f24053e679136d00c2d712e9

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M appengine/findit/crash/clusterfuzz_parser.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/crash/flag_manager.py View 2 chunks +2 lines, -3 lines 0 comments Download
M appengine/findit/crash/test/flag_manager_test.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Sharu Jiang
PTAL
3 years, 11 months ago (2017-01-03 22:34:21 UTC) #4
wrengr
lgtm
3 years, 11 months ago (2017-01-04 17:36:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610763002/20001
3 years, 11 months ago (2017-01-04 17:52:14 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 18:01:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/dcecde7f28e429a1f24053e679136...

Powered by Google App Engine
This is Rietveld 408576698