Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: appengine/findit/crash/test/flag_manager_test.py

Issue 2610763002: [Predator] Pass flags to callstack detector and fix nit. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/findit/crash/flag_manager.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from crash.flag_manager import ParsingFlag 5 from crash.flag_manager import ParsingFlag
6 from crash.flag_manager import FlagManager 6 from crash.flag_manager import FlagManager
7 from crash.test.stacktrace_test_suite import StacktraceTestSuite 7 from crash.test.stacktrace_test_suite import StacktraceTestSuite
8 8
9 9
10 class ParsingFlagTest(StacktraceTestSuite): 10 class ParsingFlagTest(StacktraceTestSuite):
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 """Tests doing nothing if flag's condition is not met.""" 108 """Tests doing nothing if flag's condition is not met."""
109 self.flag_manager.Register( 109 self.flag_manager.Register(
110 'group', 110 'group',
111 ParsingFlag('flag', 111 ParsingFlag('flag',
112 turn_on_condition=lambda line: 'flag marker' in line, 112 turn_on_condition=lambda line: 'flag marker' in line,
113 value=False)) 113 value=False))
114 line = 'dummy line' 114 line = 'dummy line'
115 self.flag_manager.ConditionallyTurnOnFlags(line) 115 self.flag_manager.ConditionallyTurnOnFlags(line)
116 self.assertFalse(bool(self.flag_manager.Get('flag'))) 116 self.assertFalse(bool(self.flag_manager.Get('flag')))
117 117
118 def testDoNothingWhenThereIsNoCondition(self):
119 """Tests doing nothing if flag has empty condition."""
120 self.flag_manager.Register(
121 'group',
122 ParsingFlag('flag', value=False))
123 line = 'dummy line'
124 self.flag_manager.ConditionallyTurnOnFlags(line)
125 self.assertFalse(bool(self.flag_manager.Get('flag')))
126
118 def testSettingFlag(self): 127 def testSettingFlag(self):
119 """Tests using ``TurnOn`` and ``TurnOff`` to set flags.""" 128 """Tests using ``TurnOn`` and ``TurnOff`` to set flags."""
120 self.flag_manager.Register('group', ParsingFlag('flag', value=False)) 129 self.flag_manager.Register('group', ParsingFlag('flag', value=False))
121 self.flag_manager.TurnOn('flag') 130 self.flag_manager.TurnOn('flag')
122 self.flag_manager.TurnOn('dummy_flag') 131 self.flag_manager.TurnOn('dummy_flag')
123 self.assertTrue(self.flag_manager.Get('flag')) 132 self.assertTrue(self.flag_manager.Get('flag'))
124 self.flag_manager.TurnOff('flag') 133 self.flag_manager.TurnOff('flag')
125 self.flag_manager.TurnOff('dummy_flag') 134 self.flag_manager.TurnOff('dummy_flag')
126 self.assertFalse(self.flag_manager.Get('flag')) 135 self.assertFalse(self.flag_manager.Get('flag'))
OLDNEW
« no previous file with comments | « appengine/findit/crash/flag_manager.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698