Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: appengine/findit/crash/test/flag_manager_test.py

Issue 2610763002: [Predator] Pass flags to callstack detector and fix nit. (Closed)
Patch Set: . Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/flag_manager.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/test/flag_manager_test.py
diff --git a/appengine/findit/crash/test/flag_manager_test.py b/appengine/findit/crash/test/flag_manager_test.py
index 6c503c208da312f511ca6db0e3f691f6ee781896..334b7ef9f83018c40eb06fcdeb351be3e6169e66 100644
--- a/appengine/findit/crash/test/flag_manager_test.py
+++ b/appengine/findit/crash/test/flag_manager_test.py
@@ -115,6 +115,15 @@ class FlagManagerTest(StacktraceTestSuite):
self.flag_manager.ConditionallyTurnOnFlags(line)
self.assertFalse(bool(self.flag_manager.Get('flag')))
+ def testDoNothingWhenThereIsNoCondition(self):
+ """Tests doing nothing if flag has empty condition."""
+ self.flag_manager.Register(
+ 'group',
+ ParsingFlag('flag', value=False))
+ line = 'dummy line'
+ self.flag_manager.ConditionallyTurnOnFlags(line)
+ self.assertFalse(bool(self.flag_manager.Get('flag')))
+
def testSettingFlag(self):
"""Tests using ``TurnOn`` and ``TurnOff`` to set flags."""
self.flag_manager.Register('group', ParsingFlag('flag', value=False))
« no previous file with comments | « appengine/findit/crash/flag_manager.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698