Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Side by Side Diff: appengine/findit/crash/clusterfuzz_parser.py

Issue 2610763002: [Predator] Pass flags to callstack detector and fix nit. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | appengine/findit/crash/flag_manager.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 import re 6 import re
7 7
8 from crash import callstack_detectors 8 from crash import callstack_detectors
9 from crash.callstack_filters import FilterFramesAfterBlinkGeneratedCode 9 from crash.callstack_filters import FilterFramesAfterBlinkGeneratedCode
10 from crash.callstack_filters import FilterJavaJreSdkFrames 10 from crash.callstack_filters import FilterJavaJreSdkFrames
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 signature or '', job_type) 97 signature or '', job_type)
98 return None 98 return None
99 99
100 # Initial background callstack which is not to be added into Stacktrace. 100 # Initial background callstack which is not to be added into Stacktrace.
101 stack_buffer = CallStackBuffer() 101 stack_buffer = CallStackBuffer()
102 # Reset both stacktrace and callstack flags. 102 # Reset both stacktrace and callstack flags.
103 self.flag_manager.ResetAllFlags() 103 self.flag_manager.ResetAllFlags()
104 for line in stacktrace_string.splitlines(): 104 for line in stacktrace_string.splitlines():
105 # Note, some flags like is_first_stack may be changed inside of stack 105 # Note, some flags like is_first_stack may be changed inside of stack
106 # detector. 106 # detector.
107 start_of_callstack = stack_detector(line) 107 start_of_callstack = stack_detector(line, flags=self.flag_manager)
108 108
109 if start_of_callstack: 109 if start_of_callstack:
110 stacktrace_buffer.AddFilteredStack( 110 stacktrace_buffer.AddFilteredStack(
111 self.UpdateMetadataWithFlags(stack_buffer)) 111 self.UpdateMetadataWithFlags(stack_buffer))
112 # Create new stack and reset callstack scope flags. 112 # Create new stack and reset callstack scope flags.
113 stack_buffer = CallStackBuffer.FromStartOfCallStack(start_of_callstack) 113 stack_buffer = CallStackBuffer.FromStartOfCallStack(start_of_callstack)
114 self.flag_manager.ResetGroupFlags(CALLSTACK_FLAG_GROUP) 114 self.flag_manager.ResetGroupFlags(CALLSTACK_FLAG_GROUP)
115 else: 115 else:
116 frame = StackFrame.Parse(stack_buffer.language_type, 116 frame = StackFrame.Parse(stack_buffer.language_type,
117 stack_buffer.format_type, line, deps, 117 stack_buffer.format_type, line, deps,
118 len(stack_buffer.frames)) 118 len(stack_buffer.frames))
119 if frame is not None: 119 if frame is not None:
120 stack_buffer.frames.append(frame) 120 stack_buffer.frames.append(frame)
121 # Turn on flags if condition met. 121 # Turn on flags if condition met.
122 self.flag_manager.ConditionallyTurnOnFlags(line) 122 self.flag_manager.ConditionallyTurnOnFlags(line)
123 123
124 # Add the last stack to stacktrace. 124 # Add the last stack to stacktrace.
125 stacktrace_buffer.AddFilteredStack( 125 stacktrace_buffer.AddFilteredStack(
126 self.UpdateMetadataWithFlags(stack_buffer)) 126 self.UpdateMetadataWithFlags(stack_buffer))
127 return stacktrace_buffer.ToStacktrace() 127 return stacktrace_buffer.ToStacktrace()
OLDNEW
« no previous file with comments | « no previous file | appengine/findit/crash/flag_manager.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698