Tidy up XMLHttpRequest::endLoading().

Tidy up XMLHttpRequest::endLoading().

R=tyoshino
BUG=

Committed: https://crrev.com/e4f346ffb6294685a2cd9f83fde8193290bec444
Cr-Commit-Position: refs/heads/master@{#441618}

[sof, 2017-01-03 11:48:54]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 11:49:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 13:12:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 13:12:25]

Dry run: This issue passed the CQ dry run.

[sof, 2017-01-04 08:16:47]

sigbjornf@opera.com changed reviewers:
+ tyoshino@chromium.org, yhirano@chromium.org

[sof, 2017-01-04 08:16:48]

please take a look.

[tyoshino (SeeGerritForStatus), 2017-01-05 05:54:24]

also use it in passesPreflightStatusCheck() and Response::ok()?

https://codereview.chromium.org/2610653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/FetchUtils.h (right):

https://codereview.chromium.org/2610653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/FetchUtils.h:36: static bool
isSuccessfulStatusCode(int status) {
how about using the term defined in the Fetch Standard?

[200, 299] is named "ok status".

https://codereview.chromium.org/2610653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/DocumentLoader.cpp (right):

https://codereview.chromium.org/2610653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:510: if
(!FetchUtils::isSuccessfulStatusCode(status) && m_frame->owner())
just pass "m_response.httpStatusCode()" directly?

[sof, 2017-01-05 08:09:42]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 08:09:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-01-05 08:11:03]

Thanks for bringing up a pair of other places which also test status codes over
this range; extended to cover those also.

https://codereview.chromium.org/2610653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/FetchUtils.h (right):

https://codereview.chromium.org/2610653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/FetchUtils.h:36: static bool
isSuccessfulStatusCode(int status) {
On 2017/01/05 05:54:24, tyoshino wrote:
> how about using the term defined in the Fetch Standard?
> 
> [200, 299] is named "ok status".

I consider "successful" the better term, but switched regardless.

https://codereview.chromium.org/2610653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/DocumentLoader.cpp (right):

https://codereview.chromium.org/2610653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:510: if
(!FetchUtils::isSuccessfulStatusCode(status) && m_frame->owner())
On 2017/01/05 05:54:24, tyoshino wrote:
> just pass "m_response.httpStatusCode()" directly?

Done, conflated the double "if".

[tyoshino (SeeGerritForStatus), 2017-01-05 09:00:55]

lgtm!

[sof, 2017-01-05 09:54:12]

Description was changed from

==========
Tidy up XMLHttpRequest::endLoading().

R=
BUG=
==========

to

==========
Tidy up XMLHttpRequest::endLoading().

R=tyoshino
BUG=
==========

[commit-bot: I haz the power, 2017-01-05 10:11:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 10:11:54]

Dry run: This issue passed the CQ dry run.

[sof, 2017-01-05 10:34:18]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2017-01-05 10:34:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 10:39:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483612458660060,
"parent_rev": "905d6614c56392a424306cd15f7a38848e1c0986", "commit_rev":
"ba110aabd799fe4d5fc47d5df5beda989b7475d2"}

[commit-bot: I haz the power, 2017-01-05 10:39:35]

Description was changed from

==========
Tidy up XMLHttpRequest::endLoading().

R=tyoshino
BUG=
==========

to

==========
Tidy up XMLHttpRequest::endLoading().

R=tyoshino
BUG=

Review-Url: https://codereview.chromium.org/2610653002
==========

[commit-bot: I haz the power, 2017-01-05 10:39:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-05 10:41:41]

Description was changed from

==========
Tidy up XMLHttpRequest::endLoading().

R=tyoshino
BUG=

Review-Url: https://codereview.chromium.org/2610653002
==========

to

==========
Tidy up XMLHttpRequest::endLoading().

R=tyoshino
BUG=

Committed: https://crrev.com/e4f346ffb6294685a2cd9f83fde8193290bec444
Cr-Commit-Position: refs/heads/master@{#441618}
==========

[commit-bot: I haz the power, 2017-01-05 10:41:42]

Patchset 2 (id:??) landed as
https://crrev.com/e4f346ffb6294685a2cd9f83fde8193290bec444
Cr-Commit-Position: refs/heads/master@{#441618}