Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2610653002: Tidy up XMLHttpRequest::endLoading(). (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, haraken, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy up XMLHttpRequest::endLoading(). R=tyoshino BUG= Committed: https://crrev.com/e4f346ffb6294685a2cd9f83fde8193290bec444 Cr-Commit-Position: refs/heads/master@{#441618}

Patch Set 1 #

Total comments: 4

Patch Set 2 : alpha conversion + use it at two more call sites #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
M third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchUtils.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 2 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
sof
please take a look.
3 years, 11 months ago (2017-01-04 08:16:48 UTC) #6
tyoshino (SeeGerritForStatus)
also use it in passesPreflightStatusCheck() and Response::ok()? https://codereview.chromium.org/2610653002/diff/1/third_party/WebKit/Source/core/fetch/FetchUtils.h File third_party/WebKit/Source/core/fetch/FetchUtils.h (right): https://codereview.chromium.org/2610653002/diff/1/third_party/WebKit/Source/core/fetch/FetchUtils.h#newcode36 third_party/WebKit/Source/core/fetch/FetchUtils.h:36: static bool ...
3 years, 11 months ago (2017-01-05 05:54:24 UTC) #7
sof
Thanks for bringing up a pair of other places which also test status codes over ...
3 years, 11 months ago (2017-01-05 08:11:03 UTC) #10
tyoshino (SeeGerritForStatus)
lgtm!
3 years, 11 months ago (2017-01-05 09:00:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610653002/20001
3 years, 11 months ago (2017-01-05 10:34:43 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-05 10:39:36 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 10:41:42 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e4f346ffb6294685a2cd9f83fde8193290bec444
Cr-Commit-Position: refs/heads/master@{#441618}

Powered by Google App Engine
This is Rietveld 408576698