third_party/WebKit/Source/modules/fetch/Response.cpp - Issue 2610653002: Tidy up XMLHttpRequest::endLoading().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/Response.cpp

Issue 2610653002: Tidy up XMLHttpRequest::endLoading(). (Closed)

Patch Set: alpha conversion + use it at two more call sites Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/fetch/Response.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/Response.cpp b/third_party/WebKit/Source/modules/fetch/Response.cpp

index 6b4300cd2726bc285c540370352a76da15f8b218..160200bb3041aa2e78fc85515f12a98f8ce3a08e 100644

--- a/third_party/WebKit/Source/modules/fetch/Response.cpp

+++ b/third_party/WebKit/Source/modules/fetch/Response.cpp

@@ -17,6 +17,7 @@

#include "core/dom/DOMArrayBuffer.h"

#include "core/dom/DOMArrayBufferView.h"

#include "core/dom/URLSearchParams.h"

+#include "core/fetch/FetchUtils.h"

#include "core/fileapi/Blob.h"

#include "core/html/FormData.h"

#include "core/streams/ReadableStreamOperations.h"

@@ -376,7 +377,7 @@ unsigned short Response::status() const {

bool Response::ok() const {

// "The ok attribute's getter must return true

// if response's status is in the range 200 to 299, and false otherwise."

- return 200 <= status() && status() <= 299;

+ return FetchUtils::isOkStatus(status());

}

String Response::statusText() const {

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchManager.cpp ('k') | no next file » | no next file with comments »