Tidy up XMLHttpRequest::endLoading().

third_party/WebKit/Source/core/loader/DocumentLoader.cpp

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 17 matching lines @@
  */
 
 #include "core/loader/DocumentLoader.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/DocumentParser.h"
 #include "core/dom/WeakIdentifierMap.h"
 #include "core/events/Event.h"
 #include "core/fetch/FetchInitiatorTypeNames.h"
 #include "core/fetch/FetchRequest.h"
+#include "core/fetch/FetchUtils.h"
 #include "core/fetch/MemoryCache.h"
 #include "core/fetch/ResourceFetcher.h"
 #include "core/frame/Deprecation.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/LocalDOMWindow.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Settings.h"
 #include "core/frame/csp/ContentSecurityPolicy.h"
 #include "core/html/HTMLFrameOwnerElement.h"
 #include "core/html/parser/HTMLDocumentParser.h"
@@ skipping 451 matching lines @@
   if (!shouldContinueForResponse()) {
     InspectorInstrumentation::continueWithPolicyIgnore(
         m_frame, this, m_mainResource->identifier(), m_response,
         m_mainResource.get());
     m_fetcher->stopFetching();
     return;
   }
 
   if (m_response.isHTTP()) {
     int status = m_response.httpStatusCode();
-    if ((status < 200 || status >= 300) && m_frame->owner())
+    if (!FetchUtils::isSuccessfulStatusCode(status) && m_frame->owner())

[tyoshino (SeeGerritForStatus), 2017/01/05 05:54:24]

just pass "m_response.httpStatusCode()" directly?

[sof, 2017/01/05 08:11:03]

Done, conflated the double "if".

       m_frame->owner()->renderFallbackContent();
   }
 }
 
 void DocumentLoader::ensureWriter(const AtomicString& mimeType,
                                   const KURL& overridingURL) {
   if (m_writer)
     return;
 
   const AtomicString& encoding = response().textEncodingName();
@@ skipping 281 matching lines @@
                              m_writer ? m_writer->encoding() : emptyAtom, true,
                              ForceSynchronousParsing);
   if (!source.isNull())
     m_writer->appendReplacingData(source);
   endWriting();
 }
 
 DEFINE_WEAK_IDENTIFIER_MAP(DocumentLoader);
 
 }  // namespace blink