third_party/WebKit/Source/modules/fetch/FetchManager.cpp - Issue 2610653002: Tidy up XMLHttpRequest::endLoading().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 2610653002: Tidy up XMLHttpRequest::endLoading(). (Closed)

Patch Set: alpha conversion + use it at two more call sites Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

index 39e8daaac8f00a839a7de5edd9c2f199df3a7b22..3937edec1d32ea38f8cee1cc5bc21149a9c8e082 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

@@ -556,7 +556,7 @@ void FetchManager::Loader::loadSucceeded() {

m_finished = true;

if (document() && document()->frame() && document()->frame()->page() &&

- m_responseHttpStatusCode >= 200 && m_responseHttpStatusCode < 300) {

+ FetchUtils::isOkStatus(m_responseHttpStatusCode)) {

document()->frame()->page()->chromeClient().ajaxSucceeded(

document()->frame());

}