Migrate WTF::Vector::append() to ::push_back() [part 9 of N]

Migrate WTF::Vector::append() to ::push_back() [part 9 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/layout/.
There are too many references to change them all at once, so this CL is
part 9 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2610253004
Cr-Commit-Position: refs/heads/master@{#442264}
Committed: https://chromium.googlesource.com/chromium/src/+/072eb5da1124e276529ba464b2765f834bff3388

[pilgrim_google, 2017-01-05 21:12:41]

Description was changed from

==========
Migrate WTF::Vector::append() to ::push_back() [part 9 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/layout/.
There are too many references to change them all at once, so this CL is
part 9 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::Vector::append() to ::push_back() [part 9 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/layout/.
There are too many references to change them all at once, so this CL is
part 9 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pilgrim_google, 2017-01-05 21:13:42]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 21:14:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pilgrim_google, 2017-01-05 21:50:37]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, yutak@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:56:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:56:57]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-01-05 23:12:11]

LGTM

[pilgrim_google, 2017-01-06 02:16:12]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2017-01-06 02:17:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 02:26:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 02:26:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pilgrim_google, 2017-01-06 14:26:37]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-01-06 14:26:37]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2610253004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-06 14:26:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 16:07:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 16:07:36]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pilgrim_google, 2017-01-09 14:55:50]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-01-09 14:55:50]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2610253004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-09 14:56:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 16:34:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483973750205500,
"parent_rev": "92cdc2fb7956c94f70bf33825b78c90353ea68d5", "commit_rev":
"072eb5da1124e276529ba464b2765f834bff3388"}

[commit-bot: I haz the power, 2017-01-09 16:34:41]

Description was changed from

==========
Migrate WTF::Vector::append() to ::push_back() [part 9 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/layout/.
There are too many references to change them all at once, so this CL is
part 9 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Migrate WTF::Vector::append() to ::push_back() [part 9 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/layout/.
There are too many references to change them all at once, so this CL is
part 9 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2610253004
Cr-Commit-Position: refs/heads/master@{#442264}
Committed:
https://chromium.googlesource.com/chromium/src/+/072eb5da1124e276529ba464b276...
==========

[commit-bot: I haz the power, 2017-01-09 16:34:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/072eb5da1124e276529ba464b276...