Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutText.cpp

Issue 2610253004: Migrate WTF::Vector::append() to ::push_back() [part 9 of N] (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutText.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutText.cpp b/third_party/WebKit/Source/core/layout/LayoutText.cpp
index 0e2a83180f184cf860b54347a86985f104d5ae2a..88a17f89c1243747ed87292b32c4fec4af2723e4 100644
--- a/third_party/WebKit/Source/core/layout/LayoutText.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutText.cpp
@@ -333,7 +333,7 @@ String LayoutText::plainText() const {
void LayoutText::absoluteRects(Vector<IntRect>& rects,
const LayoutPoint& accumulatedOffset) const {
for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox()) {
- rects.append(enclosingIntRect(LayoutRect(
+ rects.push_back(enclosingIntRect(LayoutRect(
LayoutPoint(accumulatedOffset) + box->location(), box->size())));
}
}
@@ -392,13 +392,13 @@ void LayoutText::absoluteRectsForRange(Vector<IntRect>& rects,
r.setX(selectionRect.x().toFloat());
}
}
- rects.append(localToAbsoluteQuad(r).enclosingBoundingBox());
+ rects.push_back(localToAbsoluteQuad(r).enclosingBoundingBox());
} else {
// FIXME: This code is wrong. It's converting local to absolute twice.
// http://webkit.org/b/65722
FloatRect rect = localQuadForTextBox(box, start, end, useSelectionHeight);
if (!rect.isZero())
- rects.append(localToAbsoluteQuad(rect).enclosingBoundingBox());
+ rects.push_back(localToAbsoluteQuad(rect).enclosingBoundingBox());
}
}
}
@@ -449,9 +449,9 @@ void LayoutText::quads(Vector<FloatQuad>& quads,
boundaries.setHeight(ellipsisRect.maxY() - boundaries.y());
}
if (localOrAbsolute == AbsoluteQuads)
- quads.append(localToAbsoluteQuad(boundaries, mode));
+ quads.push_back(localToAbsoluteQuad(boundaries, mode));
else
- quads.append(boundaries);
+ quads.push_back(boundaries);
}
}
@@ -499,11 +499,11 @@ void LayoutText::absoluteQuadsForRange(Vector<FloatQuad>& quads,
r.setX(selectionRect.x());
}
}
- quads.append(localToAbsoluteQuad(FloatRect(r)));
+ quads.push_back(localToAbsoluteQuad(FloatRect(r)));
} else {
FloatRect rect = localQuadForTextBox(box, start, end, useSelectionHeight);
if (!rect.isZero())
- quads.append(localToAbsoluteQuad(rect));
+ quads.push_back(localToAbsoluteQuad(rect));
}
}
}

Powered by Google App Engine
This is Rietveld 408576698