third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp - Issue 2610253004: Migrate WTF::Vector::append() to ::push_back() [part 9 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp

Issue 2610253004: Migrate WTF::Vector::append() to ::push_back() [part 9 of N] (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp b/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp

index 39637a84899dc5b680076b694c40bbf620e79630..c52beeb4b800a96c97c3cca76b7c111723f7d57c 100644

--- a/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp

+++ b/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp

@@ -613,10 +613,10 @@ void RootInlineBox::ascentAndDescentForBox(

->lineHeight()

.isNegative() &&

includeLeading)) {

- usedFonts->append(box->getLineLayoutItem()

- .style(isFirstLineStyle())

- ->font()

- .primaryFont());

+ usedFonts->push_back(box->getLineLayoutItem()

+ .style(isFirstLineStyle())

+ ->font()

+ .primaryFont());

for (size_t i = 0; i < usedFonts->size(); ++i) {

const FontMetrics& fontMetrics = usedFonts->at(i)->getFontMetrics();

int usedFontAscent = fontMetrics.ascent(baselineType());