third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc - Issue 2610253004: Migrate WTF::Vector::append() to ::push_back() [part 9 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

Issue 2610253004: Migrate WTF::Vector::append() to ::push_back() [part 9 of N] (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

index 8d377adbbbb6dae0f71ca820963daa975c3f905c..869deda1f4fa5782ffa07c7d9634572d94b278da 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

@@ -16,7 +16,7 @@ void CollectAllOpportunities(const NGLayoutOpportunityTreeNode* node,

if (!node)

return;

if (node->IsLeafNode())

- opportunities.append(node->opportunity);

+ opportunities.push_back(node->opportunity);

CollectAllOpportunities(node->left, opportunities);

CollectAllOpportunities(node->bottom, opportunities);

CollectAllOpportunities(node->right, opportunities);

@@ -176,7 +176,7 @@ void InsertExclusion(NGLayoutOpportunityTreeNode* node,

NGLayoutOpportunity top_layout_opp =

GetTopSpace(node->opportunity, exclusion->rect);

if (!top_layout_opp.IsEmpty())

- opportunities.append(top_layout_opp);

+ opportunities.push_back(top_layout_opp);

node->exclusion = exclusion;

}