Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: ios/chrome/browser/favicon/BUILD.gn

Issue 2609363003: Remove ChromeBrowserProvider::GetFaviconForURL(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("favicon") { 5 source_set("favicon") {
6 configs += [ "//build/config/compiler:enable_arc" ] 6 configs += [ "//build/config/compiler:enable_arc" ]
7 sources = [ 7 sources = [
8 "favicon_attributes.h", 8 "favicon_attributes.h",
9 "favicon_attributes.mm", 9 "favicon_attributes.mm",
10 "favicon_attributes_provider.h", 10 "favicon_attributes_provider.h",
11 "favicon_attributes_provider.mm", 11 "favicon_attributes_provider.mm",
12 "favicon_client_impl.h", 12 "favicon_client_impl.h",
13 "favicon_client_impl.mm", 13 "favicon_client_impl.mm",
14 "favicon_loader.h", 14 "favicon_loader.h",
15 "favicon_loader.mm", 15 "favicon_loader.mm",
16 "favicon_service_factory.cc", 16 "favicon_service_factory.cc",
17 "favicon_service_factory.h", 17 "favicon_service_factory.h",
18 "ios_chrome_favicon_loader_factory.h", 18 "ios_chrome_favicon_loader_factory.h",
19 "ios_chrome_favicon_loader_factory.mm", 19 "ios_chrome_favicon_loader_factory.mm",
20 "ios_chrome_large_icon_cache_factory.cc", 20 "ios_chrome_large_icon_cache_factory.cc",
21 "ios_chrome_large_icon_cache_factory.h", 21 "ios_chrome_large_icon_cache_factory.h",
22 "ios_chrome_large_icon_service_factory.cc", 22 "ios_chrome_large_icon_service_factory.cc",
23 "ios_chrome_large_icon_service_factory.h", 23 "ios_chrome_large_icon_service_factory.h",
24 "large_icon_cache.cc", 24 "large_icon_cache.cc",
25 "large_icon_cache.h", 25 "large_icon_cache.h",
26 ] 26 ]
27 deps = [ 27 deps = [
rohitrao (ping after 24h) 2017/01/04 12:36:06 Should this depend on //ios/chrome/browser/ui/webu
28 "//base", 28 "//base",
29 "//components/favicon/core", 29 "//components/favicon/core",
30 "//components/favicon_base", 30 "//components/favicon_base",
31 "//components/keyed_service/core", 31 "//components/keyed_service/core",
32 "//components/keyed_service/ios", 32 "//components/keyed_service/ios",
33 "//ios/chrome/browser", 33 "//ios/chrome/browser",
34 "//ios/chrome/browser/browser_state", 34 "//ios/chrome/browser/browser_state",
35 "//ios/chrome/browser/history", 35 "//ios/chrome/browser/history",
36 "//ios/public/provider/chrome/browser",
37 "//ios/web", 36 "//ios/web",
38 "//skia", 37 "//skia",
39 "//ui/gfx", 38 "//ui/gfx",
40 "//url", 39 "//url",
41 ] 40 ]
42 } 41 }
43 42
44 source_set("unit_tests") { 43 source_set("unit_tests") {
45 testonly = true 44 testonly = true
46 sources = [ 45 sources = [
47 "large_icon_cache_unittest.cc", 46 "large_icon_cache_unittest.cc",
48 ] 47 ]
49 deps = [ 48 deps = [
50 ":favicon", 49 ":favicon",
51 "//base", 50 "//base",
52 "//components/favicon_base", 51 "//components/favicon_base",
53 "//skia", 52 "//skia",
54 "//testing/gtest", 53 "//testing/gtest",
55 "//ui/gfx", 54 "//ui/gfx",
56 "//ui/gfx:test_support", 55 "//ui/gfx:test_support",
57 ] 56 ]
58 } 57 }
OLDNEW
« no previous file with comments | « ios/chrome/browser/downstream_chromium_browser_provider.mm ('k') | ios/chrome/browser/favicon/favicon_client_impl.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698