Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Issue 2611963002: Remove ChromeBrowserProvider::CreateSyncedWindowDelegatesGetter(). (Closed)

Created:
3 years, 11 months ago by sdefresne
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sync-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ChromeBrowserProvider::CreateSyncedWindowDelegatesGetter(). The method can now be inlined at the call site as the implementation has been upstreamed. Removing the method and obsolete includes. BUG=676278 Review-Url: https://codereview.chromium.org/2611963002 Cr-Commit-Position: refs/heads/master@{#442221} Committed: https://chromium.googlesource.com/chromium/src/+/cab7ef9c241ae9e42cea3b6860bf724f5b5d8fca

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -114 lines) Patch
M ios/chrome/browser/downstream_chromium_browser_provider.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/downstream_chromium_browser_provider.mm View 1 chunk +0 lines, -14 lines 0 comments Download
M ios/chrome/browser/sync/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sync/ios_chrome_sync_client.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/tabs/BUILD.gn View 3 chunks +5 lines, -4 lines 0 comments Download
M ios/public/provider/chrome/browser/BUILD.gn View 1 3 chunks +0 lines, -4 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 2 chunks +0 lines, -8 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.mm View 2 chunks +0 lines, -7 lines 0 comments Download
D ios/public/provider/chrome/browser/sessions/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D ios/public/provider/chrome/browser/sessions/test_synced_window_delegates_getter.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ios/public/provider/chrome/browser/sessions/test_synced_window_delegates_getter.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M ios/public/provider/chrome/browser/test_chrome_browser_provider.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/public/provider/chrome/browser/test_chrome_browser_provider.mm View 2 chunks +0 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (10 generated)
sdefresne
Please take a look.
3 years, 11 months ago (2017-01-04 11:08:06 UTC) #4
rohitrao (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-04 12:33:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611963002/40001
3 years, 11 months ago (2017-01-09 08:49:45 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 09:57:34 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cab7ef9c241ae9e42cea3b6860bf...

Powered by Google App Engine
This is Rietveld 408576698