Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.h

Issue 2609363003: Remove ChromeBrowserProvider::GetFaviconForURL(). (Closed)
Patch Set: Remove incorrect include and obsolete deps. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.h
diff --git a/ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.h b/ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.h
index 50300972b04b2e31ecce252b8810208042535186..7b3fa59c64437d4ef3b1734fa3abf8a934eef959 100644
--- a/ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.h
+++ b/ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.h
@@ -9,18 +9,8 @@
#include "base/macros.h"
#include "base/memory/singleton.h"
-#include "components/favicon_base/favicon_callback.h"
#include "ios/web/public/webui/web_ui_ios.h"
#include "ios/web/public/webui/web_ui_ios_controller_factory.h"
-#include "ui/base/layout.h"
-
-namespace base {
-class RefCountedMemory;
-}
-
-namespace ios {
-class ChromeBrowserState;
-}
class GURL;
@@ -32,14 +22,6 @@ class ChromeWebUIIOSControllerFactory : public web::WebUIIOSControllerFactory {
static ChromeWebUIIOSControllerFactory* GetInstance();
- // Get the favicon for |page_url| and run |callback| with result when loaded.
- // Note. |callback| is always run asynchronously.
- void GetFaviconForURL(
- ios::ChromeBrowserState* browser_state,
- const GURL& page_url,
- const std::vector<int>& desired_sizes_in_pixel,
- const favicon_base::FaviconResultsCallback& callback) const;
-
protected:
ChromeWebUIIOSControllerFactory();
~ChromeWebUIIOSControllerFactory() override;
@@ -47,14 +29,6 @@ class ChromeWebUIIOSControllerFactory : public web::WebUIIOSControllerFactory {
private:
friend struct base::DefaultSingletonTraits<ChromeWebUIIOSControllerFactory>;
- // Gets the data for the favicon for a WebUIIOS page. Returns nullptr if the
- // WebUIIOS does not have a favicon.
- // The returned favicon data must be |gfx::kFaviconSize| x |gfx::kFaviconSize|
- // DIP. GetFaviconForURL() should be updated if this changes.
- base::RefCountedMemory* GetFaviconResourceBytes(
- const GURL& page_url,
- ui::ScaleFactor scale_factor) const;
-
DISALLOW_COPY_AND_ASSIGN(ChromeWebUIIOSControllerFactory);
};
« no previous file with comments | « ios/chrome/browser/ui/webui/BUILD.gn ('k') | ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698