Remove mojo::String.

Remove mojo::String.

BUG=674766
Committed: https://crrev.com/5a2900a7420186d0484b21db0c9e5c342e20d534
Cr-Commit-Position: refs/heads/master@{#441603}

[Sam McNally, 2016-12-28 03:15:35]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 03:15:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-28 03:43:49]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 03:44:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 04:29:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 04:29:03]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Sam McNally, 2016-12-28 04:37:27]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 04:37:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-28 04:50:52]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 04:51:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-28 05:00:21]

Patchset #3 (id:40001) has been deleted

[Sam McNally, 2016-12-28 05:00:23]

Patchset #2 (id:20001) has been deleted

[Sam McNally, 2016-12-28 05:00:25]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-12-28 06:30:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 06:30:04]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-12-28 10:24:14]

sammc@chromium.org changed reviewers:
+ yzshen@chromium.org

[yzshen1, 2017-01-03 21:44:41]

https://codereview.chromium.org/2608513002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
(right):

https://codereview.chromium.org/2608513002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_status_collector_browsertest.cc:228:
std::string status,
Please use const&. (here and elsewhere)

https://codereview.chromium.org/2608513002/diff/60001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc (left):

https://codereview.chromium.org/2608513002/diff/60001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc:204: test_array
= Array<String>(3);
Please consider keeping this test case, using
Array<base::Optional<std::string>>.

https://codereview.chromium.org/2608513002/diff/60001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/wtf_types_unittest.cc (right):

https://codereview.chromium.org/2608513002/diff/60001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/wtf_types_unittest.cc:170: Array<std::string>
strs2;
Array<base::Optional<std::string>>?

https://codereview.chromium.org/2608513002/diff/60001/services/ui/ws/test_cha...
File services/ui/ws/test_change_tracker.h (right):

https://codereview.chromium.org/2608513002/diff/60001/services/ui/ws/test_cha...
services/ui/ws/test_change_tracker.h:168: std::string name,
Please use const&

[Sam McNally, 2017-01-03 23:41:19]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 23:41:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-01-03 23:42:17]

Patchset #4 (id:120001) has been deleted

[Sam McNally, 2017-01-03 23:43:58]

Patchset #3 (id:100001) has been deleted

[Sam McNally, 2017-01-03 23:44:09]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[Sam McNally, 2017-01-03 23:44:28]

https://codereview.chromium.org/2608513002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
(right):

https://codereview.chromium.org/2608513002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_status_collector_browsertest.cc:228:
std::string status,
On 2017/01/03 21:44:41, yzshen1 wrote:
> Please use const&. (here and elsewhere)

Done.

https://codereview.chromium.org/2608513002/diff/60001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc (left):

https://codereview.chromium.org/2608513002/diff/60001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc:204: test_array
= Array<String>(3);
On 2017/01/03 21:44:41, yzshen1 wrote:
> Please consider keeping this test case, using
> Array<base::Optional<std::string>>.

Done.

https://codereview.chromium.org/2608513002/diff/60001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/wtf_types_unittest.cc (right):

https://codereview.chromium.org/2608513002/diff/60001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/wtf_types_unittest.cc:170: Array<std::string>
strs2;
On 2017/01/03 21:44:41, yzshen1 wrote:
> Array<base::Optional<std::string>>?

Done.

https://codereview.chromium.org/2608513002/diff/60001/services/ui/ws/test_cha...
File services/ui/ws/test_change_tracker.h (right):

https://codereview.chromium.org/2608513002/diff/60001/services/ui/ws/test_cha...
services/ui/ws/test_change_tracker.h:168: std::string name,
On 2017/01/03 21:44:41, yzshen1 wrote:
> Please use const&

Done.

[commit-bot: I haz the power, 2017-01-03 23:44:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 23:47:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 23:47:55]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[yzshen1, 2017-01-04 00:05:35]

LGTM with one nit

https://codereview.chromium.org/2608513002/diff/140001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc (right):

https://codereview.chromium.org/2608513002/diff/140001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc:205:
optional_test_array[i] = base::nullopt;
They are nullopt by default, right?

[Sam McNally, 2017-01-04 00:25:01]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 00:25:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-01-04 00:28:24]

sammc@chromium.org changed reviewers:
+ dcheng@chromium.org, jam@chromium.org

[Sam McNally, 2017-01-04 00:28:25]

+dcheng for the type converters

+jam for everything outside //mojo

https://codereview.chromium.org/2608513002/diff/140001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc (right):

https://codereview.chromium.org/2608513002/diff/140001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc:205:
optional_test_array[i] = base::nullopt;
On 2017/01/04 00:05:35, yzshen1 wrote:
> They are nullopt by default, right?

Done.

[dcheng, 2017-01-04 00:32:32]

rs lgtm for type converters, thanks for cleaning this up!

[commit-bot: I haz the power, 2017-01-04 02:50:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 02:50:39]

Dry run: This issue passed the CQ dry run.

[jam, 2017-01-04 16:58:14]

lgtm

[Sam McNally, 2017-01-04 22:45:05]

Patchset #6 (id:200001) has been deleted

[Sam McNally, 2017-01-04 22:59:37]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 23:00:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 23:04:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 23:04:17]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2017-01-05 01:58:49]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2017-01-05 01:58:50]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2608513002/#ps180001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-05 01:59:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 06:14:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 06:14:47]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2017-01-05 06:21:28]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2017-01-05 06:21:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 07:45:57]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1483597288034850,
"parent_rev": "bec4e4b6f964a7958256d3fed01dd3dc8120737c", "commit_rev":
"8cee6ff552f5509dbafbf4ff0151dd3571221375"}

[commit-bot: I haz the power, 2017-01-05 07:46:30]

Description was changed from

==========
Remove mojo::String.

BUG=674766
==========

to

==========
Remove mojo::String.

BUG=674766

Review-Url: https://codereview.chromium.org/2608513002
==========

[commit-bot: I haz the power, 2017-01-05 07:46:34]

Committed patchset #5 (id:180001)

[commit-bot: I haz the power, 2017-01-05 07:48:17]

Description was changed from

==========
Remove mojo::String.

BUG=674766

Review-Url: https://codereview.chromium.org/2608513002
==========

to

==========
Remove mojo::String.

BUG=674766

Committed: https://crrev.com/5a2900a7420186d0484b21db0c9e5c342e20d534
Cr-Commit-Position: refs/heads/master@{#441603}
==========

[commit-bot: I haz the power, 2017-01-05 07:48:18]

Patchset 5 (id:??) landed as
https://crrev.com/5a2900a7420186d0484b21db0c9e5c342e20d534
Cr-Commit-Position: refs/heads/master@{#441603}