Remove internal uses of mojo::Array and mojo::WTFArray.

Remove internal uses of mojo::Array and mojo::WTFArray.

This changes the following to use std::vector/WTF::Vector instead of the
wrapper types:
- Struct::Serialize()/Deserialize()
- Internal storage of NativeStruct

BUG=674766
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2604953003
Cr-Commit-Position: refs/heads/master@{#442436}
Committed: https://chromium.googlesource.com/chromium/src/+/fd1748672f6e2f79693dc01bb868c8bf9edaa035

[Sam McNally, 2016-12-28 05:34:18]

Description was changed from

==========
Remove internal uses and ArrayTraits for mojo::Array and mojo::WTFArray.

This changes the following uses to use std::vector/WTF::Vector instead
of the wrapper types:
- Struct::Serialize()/Deserialize()
- Internal storage of NativeStruct

BUG=674766
==========

to

==========
Remove internal uses and ArrayTraits for mojo::Array and mojo::WTFArray.

This changes the following uses to use std::vector/WTF::Vector instead
of the wrapper types:
- Struct::Serialize()/Deserialize()
- Internal storage of NativeStruct

BUG=674766
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Sam McNally, 2016-12-28 05:34:29]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 05:34:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 06:19:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 06:19:24]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Sam McNally, 2016-12-28 22:51:53]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 22:52:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 00:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 00:46:22]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-12-29 03:31:42]

Description was changed from

==========
Remove internal uses and ArrayTraits for mojo::Array and mojo::WTFArray.

This changes the following uses to use std::vector/WTF::Vector instead
of the wrapper types:
- Struct::Serialize()/Deserialize()
- Internal storage of NativeStruct

BUG=674766
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove internal uses of mojo::Array and mojo::WTFArray.

This changes the following to use std::vector/WTF::Vector instead of the
wrapper types:
- Struct::Serialize()/Deserialize()
- Internal storage of NativeStruct

BUG=674766
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Sam McNally, 2016-12-29 03:44:44]

Description was changed from

==========
Remove internal uses of mojo::Array and mojo::WTFArray.

This changes the following to use std::vector/WTF::Vector instead of the
wrapper types:
- Struct::Serialize()/Deserialize()
- Internal storage of NativeStruct

BUG=674766
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove internal uses of mojo::Array and mojo::WTFArray.

This changes the following to use std::vector/WTF::Vector instead of the
wrapper types:
- Struct::Serialize()/Deserialize()
- Internal storage of NativeStruct

BUG=674766
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Sam McNally, 2016-12-29 03:44:54]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 03:45:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-29 03:59:34]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 03:59:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-29 04:29:41]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 04:29:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-29 04:30:43]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-12-29 06:14:29]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 06:14:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-29 06:14:55]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-12-29 06:15:05]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-12-29 06:15:12]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-12-29 06:15:18]

Patchset #1 (id:80001) has been deleted

[Sam McNally, 2016-12-29 06:22:37]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 06:22:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-29 06:24:50]

Patchset #1 (id:100001) has been deleted

[Sam McNally, 2016-12-29 06:34:40]

sammc@chromium.org changed reviewers:
+ yzshen@chromium.org

[commit-bot: I haz the power, 2016-12-29 07:54:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 07:54:00]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Sam McNally, 2016-12-29 09:20:32]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 09:20:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 09:50:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 09:50:41]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2017-01-03 19:26:26]

https://codereview.chromium.org/2604953003/diff/120001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/lib/hash_util.h (right):

https://codereview.chromium.org/2604953003/diff/120001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/lib/hash_util.h:67: struct
HashTraits<base::Optional<std::vector<T>>, false> {
Does it make sense to make this a template with template parameter
base::Optional<T>?

https://codereview.chromium.org/2604953003/diff/120001/mojo/public/tools/bind...
File
mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl
(right):

https://codereview.chromium.org/2604953003/diff/120001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl:53:
{%- set serialization_result_type = "Vector<uint8_t>"
Please use WTF::Vector here to be more explicit. This template file is not
located in wtf/ so readers may not realize that.

[Sam McNally, 2017-01-03 23:52:05]

https://codereview.chromium.org/2604953003/diff/120001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/lib/hash_util.h (right):

https://codereview.chromium.org/2604953003/diff/120001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/lib/hash_util.h:67: struct
HashTraits<base::Optional<std::vector<T>>, false> {
On 2017/01/03 19:26:26, yzshen1 wrote:
> Does it make sense to make this a template with template parameter
> base::Optional<T>?

I thought about that, but it seemed nicer to use std::hash except where we need
something different.

https://codereview.chromium.org/2604953003/diff/120001/mojo/public/tools/bind...
File
mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl
(right):

https://codereview.chromium.org/2604953003/diff/120001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl:53:
{%- set serialization_result_type = "Vector<uint8_t>"
On 2017/01/03 19:26:26, yzshen1 wrote:
> Please use WTF::Vector here to be more explicit. This template file is not
> located in wtf/ so readers may not realize that.

Done.

[Sam McNally, 2017-01-04 00:25:51]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 00:26:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 02:45:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 02:45:51]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2017-01-04 18:05:48]

https://codereview.chromium.org/2604953003/diff/120001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/lib/hash_util.h (right):

https://codereview.chromium.org/2604953003/diff/120001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/lib/hash_util.h:67: struct
HashTraits<base::Optional<std::vector<T>>, false> {
On 2017/01/03 23:52:04, Sam McNally wrote:
> On 2017/01/03 19:26:26, yzshen1 wrote:
> > Does it make sense to make this a template with template parameter
> > base::Optional<T>?
> 
> I thought about that, but it seemed nicer to use std::hash except where we
need
> something different.

There might be reasons that I have forgotten: why do we 

I haven't understood your idea: why having a HashTraits<base::Optional<T>>
definition will drive people away from std::hash? Would you please explain?

[yzshen1, 2017-01-04 18:06:20]

On 2017/01/04 18:05:48, yzshen1 wrote:
>
https://codereview.chromium.org/2604953003/diff/120001/mojo/public/cpp/bindin...
> File mojo/public/cpp/bindings/lib/hash_util.h (right):
> 
>
https://codereview.chromium.org/2604953003/diff/120001/mojo/public/cpp/bindin...
> mojo/public/cpp/bindings/lib/hash_util.h:67: struct
> HashTraits<base::Optional<std::vector<T>>, false> {
> On 2017/01/03 23:52:04, Sam McNally wrote:
> > On 2017/01/03 19:26:26, yzshen1 wrote:
> > > Does it make sense to make this a template with template parameter
> > > base::Optional<T>?
> > 
> > I thought about that, but it seemed nicer to use std::hash except where we
> need
> > something different.
> 
> There might be reasons that I have forgotten: why do we 
^^ Please ignore this line.

[Sam McNally, 2017-01-04 22:58:35]

https://codereview.chromium.org/2604953003/diff/120001/mojo/public/cpp/bindin...
File mojo/public/cpp/bindings/lib/hash_util.h (right):

https://codereview.chromium.org/2604953003/diff/120001/mojo/public/cpp/bindin...
mojo/public/cpp/bindings/lib/hash_util.h:67: struct
HashTraits<base::Optional<std::vector<T>>, false> {
On 2017/01/04 18:05:48, yzshen1 wrote:
> On 2017/01/03 23:52:04, Sam McNally wrote:
> > On 2017/01/03 19:26:26, yzshen1 wrote:
> > > Does it make sense to make this a template with template parameter
> > > base::Optional<T>?
> > 
> > I thought about that, but it seemed nicer to use std::hash except where we
> need
> > something different.
> 
> There might be reasons that I have forgotten: why do we 
> 
> I haven't understood your idea: why having a HashTraits<base::Optional<T>>
> definition will drive people away from std::hash? Would you please explain?

I mostly wanted to avoid the redundancy of HashTraits<base::Optional<T>> when
HashTraits<T, false> would suffice by using std::hash<T> (where T =
base::Optional<U>).

[yzshen1, 2017-01-04 23:14:59]

On 2017/01/04 22:58:35, Sam McNally wrote:
>
https://codereview.chromium.org/2604953003/diff/120001/mojo/public/cpp/bindin...
> File mojo/public/cpp/bindings/lib/hash_util.h (right):
> 
>
https://codereview.chromium.org/2604953003/diff/120001/mojo/public/cpp/bindin...
> mojo/public/cpp/bindings/lib/hash_util.h:67: struct
> HashTraits<base::Optional<std::vector<T>>, false> {
> On 2017/01/04 18:05:48, yzshen1 wrote:
> > On 2017/01/03 23:52:04, Sam McNally wrote:
> > > On 2017/01/03 19:26:26, yzshen1 wrote:
> > > > Does it make sense to make this a template with template parameter
> > > > base::Optional<T>?
> > > 
> > > I thought about that, but it seemed nicer to use std::hash except where we
> > need
> > > something different.
> > 
> > There might be reasons that I have forgotten: why do we 
> > 
> > I haven't understood your idea: why having a HashTraits<base::Optional<T>>
> > definition will drive people away from std::hash? Would you please explain?
> 
> I mostly wanted to avoid the redundancy of HashTraits<base::Optional<T>> when
> HashTraits<T, false> would suffice by using std::hash<T> (where T =
> base::Optional<U>).

Okay. LGTM

[Sam McNally, 2017-01-05 05:55:23]

sammc@chromium.org changed reviewers:
+ enne@chromium.org

[Sam McNally, 2017-01-05 05:55:24]

+enne for //cc/ipc/cc_serialization_perftest.cc

[Sam McNally, 2017-01-05 23:27:51]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 23:28:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 00:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 00:57:52]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-01-09 19:39:48]

cc lgtm, sorry for delay

[Sam McNally, 2017-01-09 22:21:24]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2017-01-09 22:21:25]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2604953003/#ps200001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-09 22:22:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 01:23:59]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1484000484866980,
"parent_rev": "7fb81a816c0395557905a28a635088206de4679a", "commit_rev":
"fd1748672f6e2f79693dc01bb868c8bf9edaa035"}

[commit-bot: I haz the power, 2017-01-10 01:24:29]

Description was changed from

==========
Remove internal uses of mojo::Array and mojo::WTFArray.

This changes the following to use std::vector/WTF::Vector instead of the
wrapper types:
- Struct::Serialize()/Deserialize()
- Internal storage of NativeStruct

BUG=674766
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove internal uses of mojo::Array and mojo::WTFArray.

This changes the following to use std::vector/WTF::Vector instead of the
wrapper types:
- Struct::Serialize()/Deserialize()
- Internal storage of NativeStruct

BUG=674766
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2604953003
Cr-Commit-Position: refs/heads/master@{#442436}
Committed:
https://chromium.googlesource.com/chromium/src/+/fd1748672f6e2f79693dc01bb868...
==========

[commit-bot: I haz the power, 2017-01-10 01:24:31]

Committed patchset #5 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/fd1748672f6e2f79693dc01bb868...