chrome/browser/ui/webui/plugins/plugins_handler.cc - Issue 2608513002: Remove mojo::String.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/plugins/plugins_handler.cc

Issue 2608513002: Remove mojo::String. (Closed)

Patch Set: rebase Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/plugins/plugins_handler.cc

diff --git a/chrome/browser/ui/webui/plugins/plugins_handler.cc b/chrome/browser/ui/webui/plugins/plugins_handler.cc

index 2c70a110270bcf033b1be2bd550250d525543d6a..cc1404b4d1f66a924408160471262a4fe6adc6ac 100644

--- a/chrome/browser/ui/webui/plugins/plugins_handler.cc

+++ b/chrome/browser/ui/webui/plugins/plugins_handler.cc

@@ -279,7 +279,7 @@ mojom::PluginFilePtr PluginsPageHandler::GeneratePluginFile(

plugin_file->enabled_mode =

GetPluginEnabledMode(plugin.name, group_name, plugin_enabled);

plugin_file->name = base::UTF16ToUTF8(plugin.name);

- plugin_file->path = mojo::String::From(plugin.path.value());

+ plugin_file->path = plugin.path.AsUTF8Unsafe();

plugin_file->type = base::UTF16ToUTF8(PluginTypeToString(plugin.type));

plugin_file->version = base::UTF16ToUTF8(plugin.version);

plugin_file->mime_types = GeneratePluginMimeTypes(plugin);