Remove mojo::Map.

Remove mojo::Map.

BUG=674766
Committed: https://crrev.com/a5b34a3cf014d113e2920bb4c52366619da27dc9
Cr-Commit-Position: refs/heads/master@{#441501}

[Sam McNally, 2016-12-28 02:28:37]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 02:28:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 02:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 02:31:08]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Sam McNally, 2016-12-28 02:33:44]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 02:33:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 03:04:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 03:04:58]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Sam McNally, 2016-12-28 03:13:34]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 03:13:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 04:26:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 04:26:08]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-12-28 04:37:21]

Patchset #2 (id:20001) has been deleted

[Sam McNally, 2016-12-28 04:37:23]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-12-28 04:52:00]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-12-28 04:52:08]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 04:52:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 06:06:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 06:06:26]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-12-28 07:26:16]

sammc@chromium.org changed reviewers:
+ yzshen@chromium.org

[Sam McNally, 2016-12-28 10:22:37]

Description was changed from

==========
Remove mojo::Map.

BUG=674766
==========

to

==========
Remove mojo::Map.

BUG=674766
==========

[yzshen1, 2017-01-03 19:07:48]

https://codereview.chromium.org/2603893002/diff/60001/services/ui/ws/drag_con...
File services/ui/ws/drag_controller.h (right):

https://codereview.chromium.org/2603893002/diff/60001/services/ui/ws/drag_con...
services/ui/ws/drag_controller.h:46: std::unordered_map<std::string,
std::vector<uint8_t>> mime_data,
Does it make sense to make this const&? It is not very common to pass copyable
objects by value.

(here and elsewhere)

[Sam McNally, 2017-01-03 23:21:40]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 23:22:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-01-03 23:24:03]

https://codereview.chromium.org/2603893002/diff/60001/services/ui/ws/drag_con...
File services/ui/ws/drag_controller.h (right):

https://codereview.chromium.org/2603893002/diff/60001/services/ui/ws/drag_con...
services/ui/ws/drag_controller.h:46: std::unordered_map<std::string,
std::vector<uint8_t>> mime_data,
On 2017/01/03 19:07:48, yzshen1 wrote:
> Does it make sense to make this const&? It is not very common to pass copyable
> objects by value.
> 
> (here and elsewhere)

Done.

[yzshen1, 2017-01-04 00:00:50]

On 2017/01/03 23:24:03, Sam McNally wrote:
>
https://codereview.chromium.org/2603893002/diff/60001/services/ui/ws/drag_con...
> File services/ui/ws/drag_controller.h (right):
> 
>
https://codereview.chromium.org/2603893002/diff/60001/services/ui/ws/drag_con...
> services/ui/ws/drag_controller.h:46: std::unordered_map<std::string,
> std::vector<uint8_t>> mime_data,
> On 2017/01/03 19:07:48, yzshen1 wrote:
> > Does it make sense to make this const&? It is not very common to pass
copyable
> > objects by value.
> > 
> > (here and elsewhere)
> 
> Done.

LGTM

[Sam McNally, 2017-01-04 00:06:22]

sammc@chromium.org changed reviewers:
+ rockot@chromium.org, sky@chromium.org

[Sam McNally, 2017-01-04 00:06:23]

+rockot for //device

+sky for //services/ui and //ui

[Sam McNally, 2017-01-04 00:24:20]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 00:24:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-01-04 00:27:31]

LGTM

[commit-bot: I haz the power, 2017-01-04 02:00:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 02:00:26]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-01-04 22:46:48]

rs lgtm

[Sam McNally, 2017-01-04 22:48:51]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2017-01-04 22:48:52]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2603893002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-04 22:49:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 22:54:42]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1483570131800640,
"parent_rev": "41802a43b71a75fb9f3600bc4a52b285b7d008f2", "commit_rev":
"4827168b23f3560b3562b4b418131a53cc00aaac"}

[commit-bot: I haz the power, 2017-01-04 22:55:09]

Description was changed from

==========
Remove mojo::Map.

BUG=674766
==========

to

==========
Remove mojo::Map.

BUG=674766

Review-Url: https://codereview.chromium.org/2603893002
==========

[commit-bot: I haz the power, 2017-01-04 22:55:11]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2017-01-04 22:57:23]

Description was changed from

==========
Remove mojo::Map.

BUG=674766

Review-Url: https://codereview.chromium.org/2603893002
==========

to

==========
Remove mojo::Map.

BUG=674766

Committed: https://crrev.com/a5b34a3cf014d113e2920bb4c52366619da27dc9
Cr-Commit-Position: refs/heads/master@{#441501}
==========

[commit-bot: I haz the power, 2017-01-04 22:57:24]

Patchset 4 (id:??) landed as
https://crrev.com/a5b34a3cf014d113e2920bb4c52366619da27dc9
Cr-Commit-Position: refs/heads/master@{#441501}