Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2608493002: Milo: Parse <br> from step text and renders the line breaks (Closed)

Created:
3 years, 12 months ago by Ryan Tseng
Modified:
3 years, 11 months ago
Reviewers:
estaab, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Parse <br> from step text and renders the line breaks BUG=670172 Review-Url: https://codereview.chromium.org/2608493002 Committed: https://github.com/luci/luci-go/commit/95bcda791c9722b5ea601b34e9ae309d12754d3d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -28 lines) Patch
M milo/appengine/buildbot/build.go View 1 3 chunks +9 lines, -1 line 0 comments Download
M milo/appengine/buildbot/expectations/win_chromium_rel_ng.246309.build.json View 9 chunks +18 lines, -9 lines 0 comments Download
M milo/appengine/frontend/expectations/bootstrap-buildbot.TestableBuild-Debug_page-_win_chromium_rel_ng_246309.html View 9 chunks +9 lines, -9 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_win_chromium_rel_ng_246309.html View 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
hinoka
ptal demo: https://1351-6eccb06-tainted-hinoka-dot-luci-milo.appspot.com/buildbot/chromium.fyi/WebKit%20Linux%20-%20RandomOrder/1068
3 years, 12 months ago (2016-12-27 23:39:13 UTC) #4
estaab
lgtm Looks good, one comment. https://codereview.chromium.org/2608493002/diff/1/milo/appengine/buildbot/build.go File milo/appengine/buildbot/build.go (right): https://codereview.chromium.org/2608493002/diff/1/milo/appengine/buildbot/build.go#newcode178 milo/appengine/buildbot/build.go:178: var rLineBreak = regexp.MustCompile("<br ...
3 years, 12 months ago (2016-12-28 00:57:13 UTC) #7
hinoka
https://codereview.chromium.org/2608493002/diff/1/milo/appengine/buildbot/build.go File milo/appengine/buildbot/build.go (right): https://codereview.chromium.org/2608493002/diff/1/milo/appengine/buildbot/build.go#newcode178 milo/appengine/buildbot/build.go:178: var rLineBreak = regexp.MustCompile("<br */*>") On 2016/12/28 00:57:13, estaab ...
3 years, 11 months ago (2016-12-28 19:29:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608493002/20001
3 years, 11 months ago (2016-12-28 19:31:31 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2016-12-28 19:36:48 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/95bcda791c9722b5ea601b34e9ae309d12754d3d

Powered by Google App Engine
This is Rietveld 408576698