Milo: Parse <br> from step text and renders the line breaks

Milo: Parse <br> from step text and renders the line breaks

BUG=670172
Review-Url: https://codereview.chromium.org/2608493002
Committed: https://github.com/luci/luci-go/commit/95bcda791c9722b5ea601b34e9ae309d12754d3d

[Ryan Tseng, 2016-12-27 23:38:43]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 23:38:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2016-12-27 23:39:13]

hinoka@chromium.org changed reviewers:
+ estaab@chromium.org, hinoka@chromium.org

[hinoka, 2016-12-27 23:39:13]

ptal

demo:
https://1351-6eccb06-tainted-hinoka-dot-luci-milo.appspot.com/buildbot/chromi...

[commit-bot: I haz the power, 2016-12-27 23:44:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 23:44:42]

Dry run: This issue passed the CQ dry run.

[estaab, 2016-12-28 00:57:13]

lgtm

Looks good, one comment.

https://codereview.chromium.org/2608493002/diff/1/milo/appengine/buildbot/bui...
File milo/appengine/buildbot/build.go (right):

https://codereview.chromium.org/2608493002/diff/1/milo/appengine/buildbot/bui...
milo/appengine/buildbot/build.go:178: var rLineBreak = regexp.MustCompile("<br
*/*>")
use "<br */?>" since only zero or one slash is expected.

[Ryan Tseng, 2016-12-28 19:26:46]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 19:26:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2016-12-28 19:29:44]

https://codereview.chromium.org/2608493002/diff/1/milo/appengine/buildbot/bui...
File milo/appengine/buildbot/build.go (right):

https://codereview.chromium.org/2608493002/diff/1/milo/appengine/buildbot/bui...
milo/appengine/buildbot/build.go:178: var rLineBreak = regexp.MustCompile("<br
*/*>")
On 2016/12/28 00:57:13, estaab wrote:
> use "<br */?>" since only zero or one slash is expected.

Done.

[hinoka, 2016-12-28 19:31:20]

The CQ bit was unchecked by hinoka@chromium.org

[hinoka, 2016-12-28 19:31:23]

The CQ bit was checked by hinoka@chromium.org

[hinoka, 2016-12-28 19:31:23]

The patchset sent to the CQ was uploaded after l-g-t-m from estaab@chromium.org
Link to the patchset: https://codereview.chromium.org/2608493002/#ps20001
(title: "Review")

[commit-bot: I haz the power, 2016-12-28 19:31:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 19:36:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482953483333790,
"parent_rev": "6eccb06f2227ce46fdabf854eb526d10f6878efe", "commit_rev":
"95bcda791c9722b5ea601b34e9ae309d12754d3d"}

[commit-bot: I haz the power, 2016-12-28 19:36:47]

Description was changed from

==========
Milo: Parse <br> from step text and renders the line breaks

BUG=670172
==========

to

==========
Milo: Parse <br> from step text and renders the line breaks

BUG=670172

Review-Url: https://codereview.chromium.org/2608493002
Committed:
https://github.com/luci/luci-go/commit/95bcda791c9722b5ea601b34e9ae309d12754d3d
==========

[commit-bot: I haz the power, 2016-12-28 19:36:48]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/95bcda791c9722b5ea601b34e9ae309d12754d3d