Milo: Parse <br> from step text and renders the line breaks

milo/appengine/buildbot/build.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbot
 
 import (
         "encoding/json"
         "fmt"
         "io/ioutil"
         "net/http"
         "path/filepath"
+        "regexp"
         "sort"
         "strings"
         "time"
 
         ds "github.com/luci/gae/service/datastore"
         "github.com/luci/luci-go/common/data/stringset"
         "github.com/luci/luci-go/common/logging"
         "github.com/luci/luci-go/milo/api/resp"
         "github.com/luci/luci-go/milo/common/miloerror"
         "golang.org/x/net/context"
@@ skipping 144 matching lines @@
                 Source:      source,
                 Duration:    duration,
                 Type:        resp.Summary, // This is more or less ignored.
                 LevelsDeep:  1,
                 Text:        []string{}, // Status messages.  Eg "This build failed on..xyz"
         }
 
         return sum
 }
 
+var rLineBreak = regexp.MustCompile("<br */*>")

[estaab, 2016/12/28 00:57:13]

use "<br */?>" since only zero or one slash is expected.

[hinoka, 2016/12/28 19:29:44]

Done.

+
 // components takes a full buildbot build struct and extract step info from all
 // of the steps and returns it as a list of milo Build Components.
 func components(b *buildbotBuild) (result []*resp.BuildComponent) {
         for _, step := range b.Steps {
                 if step.Hidden == true {
                         continue
                 }
                 bc := &resp.BuildComponent{
                         Label: step.Name,
-                        Text:  step.Text,
+                }
+                // Step text sometimes contains <br>, which we want to parse into new lines.
+                for _, t := range step.Text {
+                        for _, line := range rLineBreak.Split(t, -1) {
+                                bc.Text = append(bc.Text, line)
+                        }
                 }
 
                 // Figure out the status.
                 if !step.IsStarted {
                         bc.Status = resp.NotRun
                 } else if !step.IsFinished {
                         bc.Status = resp.Running
                 } else {
                         if len(step.Results) > 0 {
                                 status := int(step.Results[0].(float64))
@@ skipping 279 matching lines @@
 
         // TODO(hinoka): Do all fields concurrently.
         return &resp.MiloBuild{
                 SourceStamp:   sourcestamp(c, b),
                 Summary:       summary(c, b),
                 Components:    components(b),
                 PropertyGroup: properties(b),
                 Blame:         blame(b),
         }, nil
 }