Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2603683002: Files app: Remove closure compiler targets which are used only in tests. (Closed)

Created:
3 years, 12 months ago by fukino
Modified:
3 years, 12 months ago
Reviewers:
oka
CC:
chromium-reviews, posciak+watch_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files app: Remove closure compiler targets which are used only in tests. BUG=636289 TEST=run third_party/closure_compiler/run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/831b595d306205c2647dfd18fb00cb635625b797 Cr-Commit-Position: refs/heads/master@{#440704}

Patch Set 1 #

Messages

Total messages: 11 (6 generated)
fukino
3 years, 12 months ago (2016-12-26 08:33:08 UTC) #3
oka
lgtm
3 years, 12 months ago (2016-12-26 08:34:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603683002/1
3 years, 12 months ago (2016-12-26 09:00:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-26 09:26:06 UTC) #9
commit-bot: I haz the power
3 years, 12 months ago (2016-12-26 09:28:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/831b595d306205c2647dfd18fb00cb635625b797
Cr-Commit-Position: refs/heads/master@{#440704}

Powered by Google App Engine
This is Rietveld 408576698