Files app: Compile metrics-related scripts.

Files app: Compile metrics-related scripts.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2600103002
Cr-Commit-Position: refs/heads/master@{#442493}
Committed: https://chromium.googlesource.com/chromium/src/+/b00f080ca231a6e45d884b196f66ad3919b79b21

[fukino, 2016-12-26 09:00:09]

Description was changed from

==========
Files app: Compile metrics-related scripts.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
==========

to

==========
Files app: Compile metrics-related scripts.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-26 09:41:40]

fukino@chromium.org changed reviewers:
+ oka@chromium.org, smckay@chromium.org

[fukino, 2016-12-26 09:41:41]

smckay@: PTAL at third_party/analytics/compiled_resources2.gyp.
This target is needed to compile Files app with Analytics definitions using
chromium closure compiler v2 syntax.

oka@: PTAL at anything else.

[oka, 2016-12-26 10:00:58]

lgtm

[jrtorres42, 2016-12-26 16:02:50]

On 2016/12/26 10:00:58, oka wrote:
> lgtm

<String>

[Steve McKay, 2016-12-27 16:32:35]

I don't know I have much to offer on this topic now-days.

If there was anything I'd caution you to verify, it would be:

* background and foreground pages both send events with the same user id
* UMA settings is honored. I don't honestly expect that this is affected by your
changes, but it's always good to verify.

Otherwise LGTM

[fukino, 2017-01-10 01:19:24]

On 2016/12/27 16:32:35, Steve McKay wrote:
> I don't know I have much to offer on this topic now-days.
> 
> If there was anything I'd caution you to verify, it would be:
> 
> * background and foreground pages both send events with the same user id
> * UMA settings is honored. I don't honestly expect that this is affected by
your
> changes, but it's always good to verify.
> 
> Otherwise LGTM

Thanks!
This change should be safe, but I'll keep your points in mind and verify it in
following metrics-related changes.

[fukino, 2017-01-10 01:19:28]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2017-01-10 01:20:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 03:22:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:22:54]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[fukino, 2017-01-10 05:07:31]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2017-01-10 05:08:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 05:17:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484024851388030,
"parent_rev": "db329d07d614aae9a2a3993525d49c75c92ab834", "commit_rev":
"b00f080ca231a6e45d884b196f66ad3919b79b21"}

[commit-bot: I haz the power, 2017-01-10 05:18:37]

Description was changed from

==========
Files app: Compile metrics-related scripts.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files app: Compile metrics-related scripts.

BUG=636289
TEST=run third_party/closure_compiler/run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2600103002
Cr-Commit-Position: refs/heads/master@{#442493}
Committed:
https://chromium.googlesource.com/chromium/src/+/b00f080ca231a6e45d884b196f66...
==========

[commit-bot: I haz the power, 2017-01-10 05:18:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b00f080ca231a6e45d884b196f66...