Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2603193002: [modules] Make @@toStringTag on namespace objects non-configurable. (Closed)

Created:
3 years, 11 months ago by neis
Modified:
3 years, 11 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Make @@toStringTag on namespace objects non-configurable. See https://github.com/tc39/ecma262/pull/747. R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2603193002 Cr-Commit-Position: refs/heads/master@{#42057} Committed: https://chromium.googlesource.com/v8/v8/+/d946a27e039457514db31a9da319d72a33c4e732

Patch Set 1 #

Patch Set 2 : Skip test262 tests and add 'delete' test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/modules-namespace1.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
neis
3 years, 11 months ago (2017-01-02 10:59:14 UTC) #1
adamk
lgtm
3 years, 11 months ago (2017-01-03 18:48:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2603193002/20001
3 years, 11 months ago (2017-01-04 06:08:19 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 06:33:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d946a27e039457514db31a9da319d72a33c...

Powered by Google App Engine
This is Rietveld 408576698