src/bootstrapper.cc - Issue 2603193002: [modules] Make @@toStringTag on namespace objects non-configurable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 2603193002: [modules] Make @@toStringTag on namespace objects non-configurable. (Closed)

Patch Set: Skip test262 tests and add 'delete' test. Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index d02e55f350f528743b9f8974f92198965ec696be..6f07990d18a2ae1b1744753cc16932702f67b687 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -2557,7 +2557,7 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,

{ // Install @@toStringTag.

PropertyAttributes attribs =

- static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY);

+ static_cast<PropertyAttributes>(DONT_DELETE | DONT_ENUM | READ_ONLY);

Descriptor d = Descriptor::DataConstant(

factory->to_string_tag_symbol(),

factory->NewStringFromAsciiChecked("Module"), attribs);

« no previous file with comments | « no previous file | test/mjsunit/modules-namespace1.js » ('j') | no next file with comments »