Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: src/bootstrapper.cc

Issue 2603193002: [modules] Make @@toStringTag on namespace objects non-configurable. (Closed)
Patch Set: Skip test262 tests and add 'delete' test. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/modules-namespace1.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/bootstrapper.h" 5 #include "src/bootstrapper.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/base/ieee754.h" 9 #include "src/base/ieee754.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2539 matching lines...) Expand 10 before | Expand all | Expand 10 after
2550 2550
2551 { // -- J S M o d u l e N a m e s p a c e 2551 { // -- J S M o d u l e N a m e s p a c e
2552 Handle<Map> map = 2552 Handle<Map> map =
2553 factory->NewMap(JS_MODULE_NAMESPACE_TYPE, JSModuleNamespace::kSize); 2553 factory->NewMap(JS_MODULE_NAMESPACE_TYPE, JSModuleNamespace::kSize);
2554 Map::SetPrototype(map, isolate->factory()->null_value()); 2554 Map::SetPrototype(map, isolate->factory()->null_value());
2555 Map::EnsureDescriptorSlack(map, 1); 2555 Map::EnsureDescriptorSlack(map, 1);
2556 native_context()->set_js_module_namespace_map(*map); 2556 native_context()->set_js_module_namespace_map(*map);
2557 2557
2558 { // Install @@toStringTag. 2558 { // Install @@toStringTag.
2559 PropertyAttributes attribs = 2559 PropertyAttributes attribs =
2560 static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY); 2560 static_cast<PropertyAttributes>(DONT_DELETE | DONT_ENUM | READ_ONLY);
2561 Descriptor d = Descriptor::DataConstant( 2561 Descriptor d = Descriptor::DataConstant(
2562 factory->to_string_tag_symbol(), 2562 factory->to_string_tag_symbol(),
2563 factory->NewStringFromAsciiChecked("Module"), attribs); 2563 factory->NewStringFromAsciiChecked("Module"), attribs);
2564 map->AppendDescriptor(&d); 2564 map->AppendDescriptor(&d);
2565 } 2565 }
2566 } 2566 }
2567 2567
2568 { // -- I t e r a t o r R e s u l t 2568 { // -- I t e r a t o r R e s u l t
2569 Handle<Map> map = 2569 Handle<Map> map =
2570 factory->NewMap(JS_OBJECT_TYPE, JSIteratorResult::kSize); 2570 factory->NewMap(JS_OBJECT_TYPE, JSIteratorResult::kSize);
(...skipping 2162 matching lines...) Expand 10 before | Expand all | Expand 10 after
4733 } 4733 }
4734 4734
4735 4735
4736 // Called when the top-level V8 mutex is destroyed. 4736 // Called when the top-level V8 mutex is destroyed.
4737 void Bootstrapper::FreeThreadResources() { 4737 void Bootstrapper::FreeThreadResources() {
4738 DCHECK(!IsActive()); 4738 DCHECK(!IsActive());
4739 } 4739 }
4740 4740
4741 } // namespace internal 4741 } // namespace internal
4742 } // namespace v8 4742 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/modules-namespace1.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698