Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: test/mjsunit/modules-namespace1.js

Issue 2603193002: [modules] Make @@toStringTag on namespace objects non-configurable. (Closed)
Patch Set: Skip test262 tests and add 'delete' test. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | test/test262/test262.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/modules-namespace1.js
diff --git a/test/mjsunit/modules-namespace1.js b/test/mjsunit/modules-namespace1.js
index 6f0876aa195ce0f5c3bb74f1319e19c597e9fb10..8406efe61ed3546a0e481b90a0d8aa71170c61fb 100644
--- a/test/mjsunit/modules-namespace1.js
+++ b/test/mjsunit/modules-namespace1.js
@@ -46,10 +46,10 @@ assertSame(foo, foo.foo_again);
assertTrue(Reflect.has(foo, Symbol.toStringTag));
assertEquals("string", typeof Reflect.get(foo, Symbol.toStringTag));
assertEquals(
- {value: "Module", configurable: true, writable: false, enumerable: false},
+ {value: "Module", configurable: false, writable: false, enumerable: false},
Reflect.getOwnPropertyDescriptor(foo, Symbol.toStringTag));
-
-// TODO(neis): Clarify spec w.r.t. other symbols.
+// TODO(neis): Spec currently says the next one should return true.
+assertFalse(Reflect.deleteProperty(foo, Symbol.toStringTag));
// Nonexistant properties.
let nonexistant = ["gaga", 123, Symbol('')];
« no previous file with comments | « src/bootstrapper.cc ('k') | test/test262/test262.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698