Issue 259993006: Cleanup: Replace adjustForColumns() / offsetForColumns() with columnOffset().

Issue 259993006: Cleanup: Replace adjustForColumns() / offsetForColumns() with columnOffset(). (Closed)

Created:
6 years, 7 months ago by mstensho (USE GERRIT)

Modified:
6 years, 7 months ago

Reviewers:
rune, ojan

CC:
blink-reviews, chrishtr, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., ojan, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Cleanup: Replace adjustForColumns() / offsetForColumns() with columnOffset(). Most of the former adjustForColumns() call sites now look simpler, since they call a method that returns the offset instead of using pass-by-reference. R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172853

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -36 lines)			Patch
M	Source/core/rendering/RenderBlock.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderBlock.cpp	View	2 chunks	+8 lines, -10 lines	0 comments	Download
M	Source/core/rendering/RenderBox.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderBoxModelObject.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderInline.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	1 chunk	+3 lines, -9 lines	0 comments	Download
M	Source/core/rendering/RenderObject.cpp	View	2 chunks	+2 lines, -7 lines	0 comments	Download