Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 259993006: Cleanup: Replace adjustForColumns() / offsetForColumns() with columnOffset(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderInline.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 962 matching lines...) Expand 10 before | Expand all | Expand 10 after
973 } 973 }
974 974
975 if (renderer()->isOutOfFlowPositioned() && positionedParent->renderer()- >isInFlowPositioned() && positionedParent->renderer()->isRenderInline()) { 975 if (renderer()->isOutOfFlowPositioned() && positionedParent->renderer()- >isInFlowPositioned() && positionedParent->renderer()->isRenderInline()) {
976 LayoutSize offset = toRenderInline(positionedParent->renderer())->of fsetForInFlowPositionedInline(*toRenderBox(renderer())); 976 LayoutSize offset = toRenderInline(positionedParent->renderer())->of fsetForInFlowPositionedInline(*toRenderBox(renderer()));
977 localPoint += offset; 977 localPoint += offset;
978 } 978 }
979 } else if (parent()) { 979 } else if (parent()) {
980 if (hasCompositedLayerMapping()) { 980 if (hasCompositedLayerMapping()) {
981 // FIXME: Composited layers ignore pagination, so about the best we can do is make sure they're offset into the appropriate column. 981 // FIXME: Composited layers ignore pagination, so about the best we can do is make sure they're offset into the appropriate column.
982 // They won't split across columns properly. 982 // They won't split across columns properly.
983 LayoutSize columnOffset;
984 if (!parent()->renderer()->hasColumns() && parent()->renderer()->isD ocumentElement() && renderer()->view()->hasColumns()) 983 if (!parent()->renderer()->hasColumns() && parent()->renderer()->isD ocumentElement() && renderer()->view()->hasColumns())
985 renderer()->view()->adjustForColumns(columnOffset, localPoint); 984 localPoint += renderer()->view()->columnOffset(localPoint);
986 else 985 else
987 parent()->renderer()->adjustForColumns(columnOffset, localPoint) ; 986 localPoint += parent()->renderer()->columnOffset(localPoint);
988
989 localPoint += columnOffset;
990 } 987 }
991 988
992 if (parent()->renderer()->hasOverflowClip()) { 989 if (parent()->renderer()->hasOverflowClip()) {
993 IntSize scrollOffset = parent()->renderBox()->scrolledContentOffset( ); 990 IntSize scrollOffset = parent()->renderBox()->scrolledContentOffset( );
994 localPoint -= scrollOffset; 991 localPoint -= scrollOffset;
995 } 992 }
996 } 993 }
997 994
998 bool positionOrOffsetChanged = false; 995 bool positionOrOffsetChanged = false;
999 if (renderer()->isInFlowPositioned()) { 996 if (renderer()->isInFlowPositioned()) {
(...skipping 3007 matching lines...) Expand 10 before | Expand all | Expand 10 after
4007 } 4004 }
4008 } 4005 }
4009 4006
4010 void showLayerTree(const WebCore::RenderObject* renderer) 4007 void showLayerTree(const WebCore::RenderObject* renderer)
4011 { 4008 {
4012 if (!renderer) 4009 if (!renderer)
4013 return; 4010 return;
4014 showLayerTree(renderer->enclosingLayer()); 4011 showLayerTree(renderer->enclosingLayer());
4015 } 4012 }
4016 #endif 4013 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderInline.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698