Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/core/rendering/RenderObject.cpp

Issue 259993006: Cleanup: Replace adjustForColumns() / offsetForColumns() with columnOffset(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2287 matching lines...) Expand 10 before | Expand all | Expand 10 after
2298 return; 2298 return;
2299 2299
2300 // FIXME: this should call offsetFromContainer to share code, but I'm not su re it's ever called. 2300 // FIXME: this should call offsetFromContainer to share code, but I'm not su re it's ever called.
2301 LayoutPoint centerPoint = roundedLayoutPoint(transformState.mappedPoint()); 2301 LayoutPoint centerPoint = roundedLayoutPoint(transformState.mappedPoint());
2302 if (mode & ApplyContainerFlip && o->isBox()) { 2302 if (mode & ApplyContainerFlip && o->isBox()) {
2303 if (o->style()->isFlippedBlocksWritingMode()) 2303 if (o->style()->isFlippedBlocksWritingMode())
2304 transformState.move(toRenderBox(o)->flipForWritingModeIncludingColum ns(roundedLayoutPoint(transformState.mappedPoint())) - centerPoint); 2304 transformState.move(toRenderBox(o)->flipForWritingModeIncludingColum ns(roundedLayoutPoint(transformState.mappedPoint())) - centerPoint);
2305 mode &= ~ApplyContainerFlip; 2305 mode &= ~ApplyContainerFlip;
2306 } 2306 }
2307 2307
2308 LayoutSize columnOffset; 2308 transformState.move(o->columnOffset(roundedLayoutPoint(transformState.mapped Point())));
2309 o->adjustForColumns(columnOffset, roundedLayoutPoint(transformState.mappedPo int()));
2310 if (!columnOffset.isZero())
2311 transformState.move(columnOffset);
2312 2309
2313 if (o->hasOverflowClip()) 2310 if (o->hasOverflowClip())
2314 transformState.move(-toRenderBox(o)->scrolledContentOffset()); 2311 transformState.move(-toRenderBox(o)->scrolledContentOffset());
2315 2312
2316 o->mapLocalToContainer(repaintContainer, transformState, mode, wasFixed); 2313 o->mapLocalToContainer(repaintContainer, transformState, mode, wasFixed);
2317 } 2314 }
2318 2315
2319 const RenderObject* RenderObject::pushMappingToContainer(const RenderLayerModelO bject* ancestorToStopAt, RenderGeometryMap& geometryMap) const 2316 const RenderObject* RenderObject::pushMappingToContainer(const RenderLayerModelO bject* ancestorToStopAt, RenderGeometryMap& geometryMap) const
2320 { 2317 {
2321 ASSERT_UNUSED(ancestorToStopAt, ancestorToStopAt != this); 2318 ASSERT_UNUSED(ancestorToStopAt, ancestorToStopAt != this);
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
2390 mapLocalToContainer(repaintContainer, transformState, mode | ApplyContainerF lip | UseTransforms, wasFixed); 2387 mapLocalToContainer(repaintContainer, transformState, mode | ApplyContainerF lip | UseTransforms, wasFixed);
2391 transformState.flatten(); 2388 transformState.flatten();
2392 2389
2393 return transformState.lastPlanarPoint(); 2390 return transformState.lastPlanarPoint();
2394 } 2391 }
2395 2392
2396 LayoutSize RenderObject::offsetFromContainer(RenderObject* o, const LayoutPoint& point, bool* offsetDependsOnPoint) const 2393 LayoutSize RenderObject::offsetFromContainer(RenderObject* o, const LayoutPoint& point, bool* offsetDependsOnPoint) const
2397 { 2394 {
2398 ASSERT(o == container()); 2395 ASSERT(o == container());
2399 2396
2400 LayoutSize offset; 2397 LayoutSize offset = o->columnOffset(point);
2401
2402 o->adjustForColumns(offset, point);
2403 2398
2404 if (o->hasOverflowClip()) 2399 if (o->hasOverflowClip())
2405 offset -= toRenderBox(o)->scrolledContentOffset(); 2400 offset -= toRenderBox(o)->scrolledContentOffset();
2406 2401
2407 if (offsetDependsOnPoint) 2402 if (offsetDependsOnPoint)
2408 *offsetDependsOnPoint = hasColumns() || o->isRenderFlowThread(); 2403 *offsetDependsOnPoint = hasColumns() || o->isRenderFlowThread();
2409 2404
2410 return offset; 2405 return offset;
2411 } 2406 }
2412 2407
(...skipping 1007 matching lines...) Expand 10 before | Expand all | Expand 10 after
3420 { 3415 {
3421 if (object1) { 3416 if (object1) {
3422 const WebCore::RenderObject* root = object1; 3417 const WebCore::RenderObject* root = object1;
3423 while (root->parent()) 3418 while (root->parent())
3424 root = root->parent(); 3419 root = root->parent();
3425 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 3420 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
3426 } 3421 }
3427 } 3422 }
3428 3423
3429 #endif 3424 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698