Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: Source/core/rendering/RenderObject.h

Issue 259993006: Cleanup: Replace adjustForColumns() / offsetForColumns() with columnOffset(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 833 matching lines...) Expand 10 before | Expand all | Expand 10 after
844 } 844 }
845 IntRect pixelSnappedAbsoluteClippedOverflowRect() const; 845 IntRect pixelSnappedAbsoluteClippedOverflowRect() const;
846 virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObjec t* repaintContainer) const; 846 virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObjec t* repaintContainer) const;
847 virtual LayoutRect rectWithOutlineForRepaint(const RenderLayerModelObject* r epaintContainer, LayoutUnit outlineWidth) const; 847 virtual LayoutRect rectWithOutlineForRepaint(const RenderLayerModelObject* r epaintContainer, LayoutUnit outlineWidth) const;
848 848
849 // Given a rect in the object's coordinate space, compute a rect suitable fo r repainting 849 // Given a rect in the object's coordinate space, compute a rect suitable fo r repainting
850 // that rect in the coordinate space of repaintContainer. 850 // that rect in the coordinate space of repaintContainer.
851 virtual void computeRectForRepaint(const RenderLayerModelObject* repaintCont ainer, LayoutRect&, bool fixed = false) const; 851 virtual void computeRectForRepaint(const RenderLayerModelObject* repaintCont ainer, LayoutRect&, bool fixed = false) const;
852 virtual void computeFloatRectForRepaint(const RenderLayerModelObject* repain tContainer, FloatRect& repaintRect, bool fixed = false) const; 852 virtual void computeFloatRectForRepaint(const RenderLayerModelObject* repain tContainer, FloatRect& repaintRect, bool fixed = false) const;
853 853
854 // If multiple-column layout results in applying an offset to the given poin t, add the same 854 // Return the offset to the column in which the specified point (in flow-thr ead coordinates)
855 // offset to the given size. 855 // lives. This is used to convert a flow-thread point to a visual point.
856 virtual void adjustForColumns(LayoutSize&, const LayoutPoint&) const { } 856 virtual LayoutSize columnOffset(const LayoutPoint&) const { return LayoutSiz e(); }
857 LayoutSize offsetForColumns(const LayoutPoint& point) const
858 {
859 LayoutSize offset;
860 adjustForColumns(offset, point);
861 return offset;
862 }
863 857
864 virtual unsigned length() const { return 1; } 858 virtual unsigned length() const { return 1; }
865 859
866 bool isFloatingOrOutOfFlowPositioned() const { return (isFloating() || isOut OfFlowPositioned()); } 860 bool isFloatingOrOutOfFlowPositioned() const { return (isFloating() || isOut OfFlowPositioned()); }
867 861
868 bool isTransparent() const { return style()->opacity() < 1.0f; } 862 bool isTransparent() const { return style()->opacity() < 1.0f; }
869 float opacity() const { return style()->opacity(); } 863 float opacity() const { return style()->opacity(); }
870 864
871 bool hasReflection() const { return m_bitfields.hasReflection(); } 865 bool hasReflection() const { return m_bitfields.hasReflection(); }
872 866
(...skipping 581 matching lines...) Expand 10 before | Expand all | Expand 10 after
1454 void showTree(const WebCore::RenderObject*); 1448 void showTree(const WebCore::RenderObject*);
1455 void showLineTree(const WebCore::RenderObject*); 1449 void showLineTree(const WebCore::RenderObject*);
1456 void showRenderTree(const WebCore::RenderObject* object1); 1450 void showRenderTree(const WebCore::RenderObject* object1);
1457 // We don't make object2 an optional parameter so that showRenderTree 1451 // We don't make object2 an optional parameter so that showRenderTree
1458 // can be called from gdb easily. 1452 // can be called from gdb easily.
1459 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2); 1453 void showRenderTree(const WebCore::RenderObject* object1, const WebCore::RenderO bject* object2);
1460 1454
1461 #endif 1455 #endif
1462 1456
1463 #endif // RenderObject_h 1457 #endif // RenderObject_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698