[Findit] Flake checker: Get full build info for each flake build analyzed

[Findit] Get full build info for each flake build analyzed

This change is primarily to add blame_list information to each analyzed flake build data point. The blame list will be used for try jobs for determining the exact culprit change.

BUG=672724
Review-Url: https://codereview.chromium.org/2597373002
Committed: https://chromium.googlesource.com/infra/infra/+/53f89955d1b113d967079561b66a45f14297e9d8

[lijeffrey, 2016-12-23 00:17:14]

Description was changed from

==========
[Findit] Get full build info for each flake build analyzed

BUG=
==========

to

==========
[Findit] Get full build info for each flake build analyzed

This change is primarily to add blame_list information to each analyzed flake
build data point. The blame list will be used for try jobs for determining the
exact culprit change.

BUG=
==========

[lijeffrey, 2016-12-23 00:17:14]

lijeffrey@chromium.org changed reviewers:
+ chanli@chromium.org, robertocn@chromium.org, stgao@chromium.org

[lijeffrey, 2016-12-23 00:17:45]

ptal

[lijeffrey, 2016-12-30 00:24:36]

Description was changed from

==========
[Findit] Get full build info for each flake build analyzed

This change is primarily to add blame_list information to each analyzed flake
build data point. The blame list will be used for try jobs for determining the
exact culprit change.

BUG=
==========

to

==========
[Findit] Get full build info for each flake build analyzed

This change is primarily to add blame_list information to each analyzed flake
build data point. The blame list will be used for try jobs for determining the
exact culprit change.

BUG=672724
==========

[stgao, 2017-01-03 23:41:11]

lgtm with nits.

BTW, is the new info a duplicate of the git_hash and previous_build_git_hash?
With those two git hashes, it seems we could retrieve all the commits in
between.

https://codereview.chromium.org/2597373002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
(right):

https://codereview.chromium.org/2597373002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py:16:
def _GetBuildInfo(master_name, builder_name, build_number):
It seems better to move this function to waterfall/build_util.py instead.

https://codereview.chromium.org/2597373002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py:25:
commit_position (int), git_hash (str): The git commit position corresponding
This needs updating.

[lijeffrey, 2017-01-04 00:43:07]

This change just includes blame_list from BuildInfo, which was previously being
extracted and discarded and that blame_list will be used as the revision range
for try jobs. Is there another way to get the blame list given just the
start/end revisions?

https://codereview.chromium.org/2597373002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
(right):

https://codereview.chromium.org/2597373002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py:16:
def _GetBuildInfo(master_name, builder_name, build_number):
On 2017/01/03 23:41:11, stgao (slow on Monday) wrote:
> It seems better to move this function to waterfall/build_util.py instead.

Done.

https://codereview.chromium.org/2597373002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py:25:
commit_position (int), git_hash (str): The git commit position corresponding
On 2017/01/03 23:41:11, stgao (slow on Monday) wrote:
> This needs updating.

Done.

[stgao, 2017-01-04 17:00:36]

On 2017/01/04 00:43:07, lijeffrey wrote:
> This change just includes blame_list from BuildInfo, which was previously
being
> extracted and discarded and that blame_list will be used as the revision range
> for try jobs. Is there another way to get the blame list given just the
> start/end revisions?

GitRepository has an API to query all commits between two given git hashes,
right?
https://cs.chromium.org/chromium/infra/appengine/findit/libs/gitiles/gitiles_...

> 
>
https://codereview.chromium.org/2597373002/diff/1/appengine/findit/waterfall/...
> File appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
> (right):
> 
>
https://codereview.chromium.org/2597373002/diff/1/appengine/findit/waterfall/...
> appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py:16:
> def _GetBuildInfo(master_name, builder_name, build_number):
> On 2017/01/03 23:41:11, stgao (slow on Monday) wrote:
> > It seems better to move this function to waterfall/build_util.py instead.
> 
> Done.
> 
>
https://codereview.chromium.org/2597373002/diff/1/appengine/findit/waterfall/...
> appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py:25:
> commit_position (int), git_hash (str): The git commit position corresponding
> On 2017/01/03 23:41:11, stgao (slow on Monday) wrote:
> > This needs updating.
> 
> Done.

[lijeffrey, 2017-01-04 19:42:10]

Per discussion offline both this approach and using gitiles_repository.py's
GetCommitsBetweenRevisions should work. The calling code that will rely on
data_point.blame_list should include a comment that in case the order of the
revisions in blame_list returned from ExtractBuildInfo is incorrect or
unreliable, the revision list should be switched to GetCommitsBetweenRevisions.

[lijeffrey, 2017-01-04 19:42:17]

The CQ bit was checked by lijeffrey@chromium.org

[lijeffrey, 2017-01-04 19:42:18]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2597373002/#ps40001
(title: "Removing incorrect line")

[commit-bot: I haz the power, 2017-01-04 19:42:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 19:51:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483558937659790,
"parent_rev": "c9134731eb9816cdfd454729a4bd1027d6c5a521", "commit_rev":
"53f89955d1b113d967079561b66a45f14297e9d8"}

[commit-bot: I haz the power, 2017-01-04 19:51:26]

Description was changed from

==========
[Findit] Get full build info for each flake build analyzed

This change is primarily to add blame_list information to each analyzed flake
build data point. The blame list will be used for try jobs for determining the
exact culprit change.

BUG=672724
==========

to

==========
[Findit] Get full build info for each flake build analyzed

This change is primarily to add blame_list information to each analyzed flake
build data point. The blame list will be used for try jobs for determining the
exact culprit change.

BUG=672724

Review-Url: https://codereview.chromium.org/2597373002
Committed:
https://chromium.googlesource.com/infra/infra/+/53f89955d1b113d967079561b66a4...
==========

[commit-bot: I haz the power, 2017-01-04 19:51:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/53f89955d1b113d967079561b66a4...