Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2159)

Unified Diff: appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py

Issue 2597373002: [Findit] Flake checker: Get full build info for each flake build analyzed (Closed)
Patch Set: Removing incorrect line Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py b/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py
index 9825cbd4581a5766f047cfca3b178dea3b539413..5e1f7f802cedde0df376a5a2796295d1f68e2e09 100644
--- a/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py
+++ b/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py
@@ -9,8 +9,9 @@ from model import analysis_status
from model.flake.flake_swarming_task import FlakeSwarmingTask
from model.flake.master_flake_analysis import MasterFlakeAnalysis
from model.wf_swarming_task import WfSwarmingTask
+from waterfall import build_util
from waterfall import swarming_util
-from waterfall import process_flake_swarming_task_result_pipeline
+from waterfall.build_info import BuildInfo
from waterfall.process_base_swarming_task_result_pipeline import (
ProcessBaseSwarmingTaskResultPipeline)
from waterfall.process_flake_swarming_task_result_pipeline import (
@@ -191,10 +192,14 @@ class ProcessBaseSwarmingTaskResultPipelineTest(wf_testcase.WaterfallTestCase):
_SAMPLE_FAILURE_LOG))
self.assertEqual(_EXPECTED_TESTS_STATUS, tests_statuses)
- @mock.patch.object(process_flake_swarming_task_result_pipeline,
- '_GetCommitPositionAndGitHash',
- return_value=(12345, 'git_hash'))
- def testMonitorSwarmingTaskTimeOut(self, _):
+ @mock.patch.object(build_util, 'GetBuildInfo')
+ def testMonitorSwarmingTaskTimeOut(self, mocked_fn):
+ build_info = BuildInfo(
+ self.master_name, self.builder_name, self.build_number)
+ build_info.commit_position = 12345
+ build_info.chromium_revision = 'a1b2c3d4'
+ mocked_fn.return_value = build_info
+
# Override swarming config settings to force a timeout.
override_swarming_settings = {
'task_timeout_hours': -1

Powered by Google App Engine
This is Rietveld 408576698