[Findit] Flake checker: Get full build info for each flake build analyzed

appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from model.flake.flake_swarming_task import FlakeSwarmingTask
 from model.flake.master_flake_analysis import DataPoint
 from model.flake.master_flake_analysis import MasterFlakeAnalysis
 from waterfall import build_util
 from waterfall import buildbot
 from waterfall.process_base_swarming_task_result_pipeline import (
     ProcessBaseSwarmingTaskResultPipeline)
 
 
-def _GetCommitPositionAndGitHash(master_name, builder_name, build_number):
-  """Gets the commit position and git hash of a build.
+def _GetBuildInfo(master_name, builder_name, build_number):

[stgao, 2017/01/03 23:41:11]

It seems better to move this function to waterfall/build_util.py instead.

[lijeffrey, 2017/01/04 00:43:07]

Done.

+  """Gets build info given a master, builder, and build number.
 
   Args:
     master_name (str): The name of the master.
     builder_name (str): The name of the builder.
     build_number (int): The build number.
 
   Returns:
     commit_position (int), git_hash (str): The git commit position corresponding

[stgao, 2017/01/03 23:41:11]

This needs updating.

[lijeffrey, 2017/01/04 00:43:07]

Done.

       to the last commit in the build, and the git hash itself.
   """
-  if build_number < 0:
-    return None, None
-
   build = build_util.DownloadBuildData(master_name, builder_name, build_number)
 
   if not build.data:
-    return None, None
+    return None
 
-  build_info = buildbot.ExtractBuildInfo(
+  return buildbot.ExtractBuildInfo(
       master_name, builder_name, build_number, build.data)
 
-  return build_info.commit_position, build_info.chromium_revision
-
 
 class ProcessFlakeSwarmingTaskResultPipeline(
     ProcessBaseSwarmingTaskResultPipeline):
   """A pipeline for monitoring swarming task and processing task result.
 
   This pipeline waits for result for a swarming task and processes the result to
   generate a dict for statuses for each test run.
   """
 
   # Arguments number differs from overridden method - pylint: disable=W0221
@@ skipping 46 matching lines @@
         master_name, builder_name, build_number, step_name, test_name)
     flake_swarming_task.tries = tries
     flake_swarming_task.successes = successes
     flake_swarming_task.put()
 
     data_point = DataPoint()
     data_point.build_number = build_number
     data_point.pass_rate = pass_rate
     data_point.task_id = flake_swarming_task.task_id
 
-    # Include git commit position information about each build that was run.
+    # Include git information about each build that was run.
     if build_number > 0:
-      previous_commit, previous_build_git_hash = _GetCommitPositionAndGitHash(
+      previous_build = _GetBuildInfo(
           master_name, builder_name, build_number - 1)
-      data_point.previous_build_commit_position = previous_commit
-      data_point.previous_build_git_hash = previous_build_git_hash
+      data_point.previous_build_commit_position = previous_build.commit_position
+      data_point.previous_build_git_hash = previous_build.chromium_revision
+      data_point.blame_list = previous_build.blame_list
 
-    commit_position, git_hash = _GetCommitPositionAndGitHash(
-        master_name, builder_name, build_number)
-    data_point.commit_position = commit_position
-    data_point.git_hash = git_hash
+    build_info = _GetBuildInfo(master_name, builder_name, build_number)
+    data_point.commit_position = build_info.commit_position
+    data_point.git_hash = build_info.chromium_revision
+    data_point.blame_list = build_info.blame_list
 
     master_flake_analysis.data_points.append(data_point)
 
     results = flake_swarming_task.GetFlakeSwarmingTaskData()
     # TODO(lijeffrey): Determine whether or not this flake swarming task
     # was a cache hit (already ran results for more iterations than were
     # requested) and update results['cache_hit'] accordingly.
     master_flake_analysis.swarming_rerun_results.append(results)
     master_flake_analysis.put()
 
     return tests_statuses
 
   def _GetArgs(self, master_name, builder_name, build_number,
                step_name, *args):
     master_build_number = args[0]
     test_name = args[1]
     version_number = args[2]
     return (master_name, builder_name, build_number, step_name,
             master_build_number, test_name, version_number)
 
   # Unused Argument - pylint: disable=W0612,W0613
   # Arguments number differs from overridden method - pylint: disable=W0221
   def _GetSwarmingTask(self, master_name, builder_name, build_number,
                        step_name, master_build_number, test_name, _):
     # Gets the appropriate kind of swarming task (FlakeSwarmingTask).
     return FlakeSwarmingTask.Get(master_name, builder_name, build_number,
                                  step_name, test_name)