[Findit] Flake checker: Get full build info for each flake build analyzed

appengine/findit/waterfall/test/build_util_test.py

Index: appengine/findit/waterfall/test/build_util_test.py
diff --git a/appengine/findit/waterfall/test/build_util_test.py b/appengine/findit/waterfall/test/build_util_test.py
index d3a8b08be404567485879da7b7d5100e9f61f550..f64b5f142f082e45445834ec68647c50779e1317 100644
--- a/appengine/findit/waterfall/test/build_util_test.py
+++ b/appengine/findit/waterfall/test/build_util_test.py
@@ -3,8 +3,8 @@
 # found in the LICENSE file.
 
 import datetime
-
-from testing_utils import testing
+import json
+import mock
 
 from model.wf_build import WfBuild
 from waterfall import build_util
@@ -197,3 +197,29 @@ class BuildUtilTest(wf_testcase.WaterfallTestCase):
   def testGetBuildInfoFromId(self):
     build_id = 'm/b/1'
     self.assertEqual(build_util.GetBuildInfoFromId(build_id), ['m', 'b', '1'])
+
+  @mock.patch.object(build_util, 'DownloadBuildData')
+  def testGetBuildInfo(self, mocked_fn):
+    build = WfBuild.Create('m', 'b', 123)
+    build.data = json.dumps({
+        'properties': [
+            ['got_revision', 'a_git_hash'],
+            ['got_revision_cp', 'refs/heads/master@{#12345}']
+        ],
+    })
+    mocked_fn.return_value = build
+
+    build_info = build_util.GetBuildInfo('m', 'b', 123)
+    self.assertEqual(build_info.chromium_revision, 'a_git_hash')
+
+  @mock.patch.object(build_util, 'DownloadBuildData')
+  def testGetBuildInfoBuildNotAvailable(self, mocked_fn):
+    master_name = 'm'
+    builder_name = 'b'
+    build_number = 123
+    build = WfBuild.Create(master_name, builder_name, build_number)
+    build.data = {}
+    mocked_fn.return_value = build
+
+    self.assertIsNone(
+        build_util.GetBuildInfo(master_name, builder_name, build_number))