Use net::TestNetworkQualityEstimator in resource loader unittests

Use net::TestNetworkQualityEstimator in resource loader unittests

Use net::TestNetworkQualityEstimator in tests instead of creating
multiple overriding classes.

Also, add a new easy to use constructor for 
TestNetworkQualityEstimator.

BUG=676661
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2596983003
Cr-Commit-Position: refs/heads/master@{#442333}
Committed: https://chromium.googlesource.com/chromium/src/+/66edd71ca9b4e2691ab0d0926b7b77945c92556f

[tbansal1, 2016-12-22 07:53:59]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-12-22 07:55:05]

Description was changed from

==========
NQE test clean up

BUG=
==========

to

==========
NQE test clean up

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2016-12-22 07:55:10]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 07:55:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-12-22 07:56:27]

Description was changed from

==========
NQE test clean up

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Use net::TestNetworkQualityEstimator in resource loader unittests

Use net::TestNetworkQualityEstimator in tests instead of creating
multiple overriding classes.

Also, add a new easy to use constructor for TestNetworkQualityEstimator.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2016-12-22 07:57:34]

Description was changed from

==========
Use net::TestNetworkQualityEstimator in resource loader unittests

Use net::TestNetworkQualityEstimator in tests instead of creating
multiple overriding classes.

Also, add a new easy to use constructor for TestNetworkQualityEstimator.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Use net::TestNetworkQualityEstimator in resource loader unittests

Use net::TestNetworkQualityEstimator in tests instead of creating
multiple overriding classes.

Also, add a new easy to use constructor for 
TestNetworkQualityEstimator.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[commit-bot: I haz the power, 2016-12-22 08:53:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 08:53:32]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2016-12-22 16:40:51]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2016-12-22 16:40:51]

ryansturm: ptal. Thanks.

[tbansal1, 2016-12-22 16:42:58]

Description was changed from

==========
Use net::TestNetworkQualityEstimator in resource loader unittests

Use net::TestNetworkQualityEstimator in tests instead of creating
multiple overriding classes.

Also, add a new easy to use constructor for 
TestNetworkQualityEstimator.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Use net::TestNetworkQualityEstimator in resource loader unittests

Use net::TestNetworkQualityEstimator in tests instead of creating
multiple overriding classes.

Also, add a new easy to use constructor for 
TestNetworkQualityEstimator.

BUG=676661

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[RyanSturm, 2016-12-22 20:59:14]

net/nqe/network_qualities_prefs_manager_unittest.cc has a few constructors you
can replace with the new constructor I beleieve (they are using the two
parameter constructor with null args)

lgtm

[tbansal1, 2016-12-22 21:24:43]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[tbansal1, 2016-12-22 21:24:54]

tbansal@chromium.org changed reviewers:
+ bengr@chromium.org

[tbansal1, 2016-12-22 21:24:54]

bengr: ptal. Thanks.

[commit-bot: I haz the power, 2016-12-22 21:25:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 22:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 22:20:28]

Dry run: This issue passed the CQ dry run.

[bengr, 2017-01-03 20:50:38]

https://codereview.chromium.org/2596983003/diff/40001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
(right):

https://codereview.chromium.org/2596983003/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc:47:
#include "net/nqe/network_quality_estimator.h"
Do you still need this?

https://codereview.chromium.org/2596983003/diff/40001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
(right):

https://codereview.chromium.org/2596983003/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc:46:
#include "net/nqe/network_quality_estimator.h"
Likewise?

[mmenke, 2017-01-03 20:54:03]

content/browser/loader LGTM.

[tbansal1, 2017-01-03 21:31:26]

bengr: ptal. Thanks.

https://codereview.chromium.org/2596983003/diff/40001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
(right):

https://codereview.chromium.org/2596983003/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc:47:
#include "net/nqe/network_quality_estimator.h"
On 2017/01/03 20:50:38, bengr wrote:
> Do you still need this?

Done.

https://codereview.chromium.org/2596983003/diff/40001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
(right):

https://codereview.chromium.org/2596983003/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc:46:
#include "net/nqe/network_quality_estimator.h"
On 2017/01/03 20:50:38, bengr wrote:
> Likewise?

Done.

[tbansal1, 2017-01-03 21:31:36]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 21:32:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 22:29:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 22:29:11]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-01-07 01:04:06]

ping.

[bengr, 2017-01-09 19:15:13]

lgtm

[tbansal1, 2017-01-09 19:17:08]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-01-09 19:17:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org, mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2596983003/#ps60001
(title: "Rebased, bengr comments")

[commit-bot: I haz the power, 2017-01-09 19:18:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 20:44:08]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483989428289230,
"parent_rev": "6e397619af9370372f49a4d1281d1f19b013f501", "commit_rev":
"66edd71ca9b4e2691ab0d0926b7b77945c92556f"}

[commit-bot: I haz the power, 2017-01-09 20:44:36]

Description was changed from

==========
Use net::TestNetworkQualityEstimator in resource loader unittests

Use net::TestNetworkQualityEstimator in tests instead of creating
multiple overriding classes.

Also, add a new easy to use constructor for 
TestNetworkQualityEstimator.

BUG=676661

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Use net::TestNetworkQualityEstimator in resource loader unittests

Use net::TestNetworkQualityEstimator in tests instead of creating
multiple overriding classes.

Also, add a new easy to use constructor for 
TestNetworkQualityEstimator.

BUG=676661

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2596983003
Cr-Commit-Position: refs/heads/master@{#442333}
Committed:
https://chromium.googlesource.com/chromium/src/+/66edd71ca9b4e2691ab0d0926b7b...
==========

[commit-bot: I haz the power, 2017-01-09 20:44:37]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/66edd71ca9b4e2691ab0d0926b7b...