Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1797)

Unified Diff: net/nqe/network_qualities_prefs_manager_unittest.cc

Issue 2596983003: Use net::TestNetworkQualityEstimator in resource loader unittests (Closed)
Patch Set: Rebased, bengr comments Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/resource_loader_unittest.cc ('k') | net/nqe/network_quality_estimator_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_qualities_prefs_manager_unittest.cc
diff --git a/net/nqe/network_qualities_prefs_manager_unittest.cc b/net/nqe/network_qualities_prefs_manager_unittest.cc
index c25d43c13d18e86a7b9350d1ff4e4c2b05206ec7..bf38f2ec22e5b25bfd64ea50bac3a56cb719099e 100644
--- a/net/nqe/network_qualities_prefs_manager_unittest.cc
+++ b/net/nqe/network_qualities_prefs_manager_unittest.cc
@@ -72,8 +72,7 @@ class TestPrefDelegate : public NetworkQualitiesPrefsManager::PrefDelegate {
};
TEST(NetworkQualitiesPrefManager, Write) {
- std::map<std::string, std::string> variation_params;
- TestNetworkQualityEstimator estimator(variation_params, nullptr);
+ TestNetworkQualityEstimator estimator;
std::unique_ptr<TestPrefDelegate> prefs_delegate(new TestPrefDelegate());
TestPrefDelegate* prefs_delegate_ptr = prefs_delegate.get();
@@ -111,8 +110,7 @@ TEST(NetworkQualitiesPrefManager, Write) {
// Verify that the pref is not written if the network ID contains a period.
TEST(NetworkQualitiesPrefManager, WriteWithPeriodInNetworkID) {
- std::map<std::string, std::string> variation_params;
- TestNetworkQualityEstimator estimator(variation_params, nullptr);
+ TestNetworkQualityEstimator estimator;
std::unique_ptr<TestPrefDelegate> prefs_delegate(new TestPrefDelegate());
TestPrefDelegate* prefs_delegate_ptr = prefs_delegate.get();
@@ -138,8 +136,7 @@ TEST(NetworkQualitiesPrefManager, WriteWithPeriodInNetworkID) {
}
TEST(NetworkQualitiesPrefManager, WriteAndReadWithMultipleNetworkIDs) {
- std::map<std::string, std::string> variation_params;
- TestNetworkQualityEstimator estimator(variation_params, nullptr);
+ TestNetworkQualityEstimator estimator;
std::unique_ptr<TestPrefDelegate> prefs_delegate(new TestPrefDelegate());
@@ -236,8 +233,7 @@ TEST(NetworkQualitiesPrefManager, WriteAndReadWithMultipleNetworkIDs) {
// Verifies that the prefs are cleared correctly.
TEST(NetworkQualitiesPrefManager, ClearPrefs) {
- std::map<std::string, std::string> variation_params;
- TestNetworkQualityEstimator estimator(variation_params, nullptr);
+ TestNetworkQualityEstimator estimator;
std::unique_ptr<TestPrefDelegate> prefs_delegate(new TestPrefDelegate());
« no previous file with comments | « content/browser/loader/resource_loader_unittest.cc ('k') | net/nqe/network_quality_estimator_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698