Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

Issue 2596983003: Use net::TestNetworkQualityEstimator in resource loader unittests (Closed)
Patch Set: Rebased, bengr comments Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
index 3bb9c5695247463686e540128fd526a2e9144906..43e94116045848f32436f10d246be03705ae1b2d 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
@@ -46,7 +46,6 @@
#include "net/log/test_net_log.h"
#include "net/nqe/effective_connection_type.h"
#include "net/nqe/external_estimate_provider.h"
-#include "net/nqe/network_quality_estimator.h"
#include "net/nqe/network_quality_estimator_test_util.h"
#include "net/proxy/proxy_server.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
@@ -1022,9 +1021,7 @@ TEST_F(DataReductionProxyConfigTest, AutoLoFiParams) {
EXPECT_EQ(base::TimeDelta::FromSeconds(expected_hysteresis_sec),
config.auto_lofi_hysteresis_);
- std::map<std::string, std::string> network_quality_estimator_params;
- net::TestNetworkQualityEstimator test_network_quality_estimator(
- network_quality_estimator_params);
+ net::TestNetworkQualityEstimator test_network_quality_estimator;
// Network is slow.
test_network_quality_estimator.set_effective_connection_type(
@@ -1103,9 +1100,7 @@ TEST_F(DataReductionProxyConfigTest, AutoLoFiParamsSlowConnectionsFlag) {
EXPECT_EQ(base::TimeDelta::FromSeconds(hysteresis_sec),
config.auto_lofi_hysteresis_);
- std::map<std::string, std::string> network_quality_estimator_params;
- net::TestNetworkQualityEstimator test_network_quality_estimator(
- network_quality_estimator_params);
+ net::TestNetworkQualityEstimator test_network_quality_estimator;
// Network is slow.
test_network_quality_estimator.set_effective_connection_type(
@@ -1209,9 +1204,7 @@ TEST_F(DataReductionProxyConfigTest, LoFiAccuracy) {
<< test.description;
config.PopulateAutoLoFiParams();
- std::map<std::string, std::string> network_quality_estimator_params;
- net::TestNetworkQualityEstimator test_network_quality_estimator(
- network_quality_estimator_params);
+ net::TestNetworkQualityEstimator test_network_quality_estimator;
base::HistogramTester histogram_tester;
test_network_quality_estimator.set_effective_connection_type(
@@ -1261,9 +1254,7 @@ TEST_F(DataReductionProxyConfigTest, LoFiAccuracyNonZeroDelay) {
"Enabled");
config.PopulateAutoLoFiParams();
- std::map<std::string, std::string> network_quality_estimator_params;
- net::TestNetworkQualityEstimator test_network_quality_estimator(
- network_quality_estimator_params);
+ net::TestNetworkQualityEstimator test_network_quality_estimator;
base::HistogramTester histogram_tester;
// Network was predicted to be slow and actually was slow.
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698