Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc

Issue 2596983003: Use net::TestNetworkQualityEstimator in resource loader unittests (Closed)
Patch Set: Rebased, bengr comments Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
index d573dd3b031b5ade0232bb537f9e17b629a58349..5ba013702dd33f6f47fbff0af60ccda771e2bb50 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
@@ -45,7 +45,6 @@
#include "net/http/http_response_headers.h"
#include "net/http/http_util.h"
#include "net/nqe/effective_connection_type.h"
-#include "net/nqe/network_quality_estimator.h"
#include "net/nqe/network_quality_estimator_test_util.h"
#include "net/proxy/proxy_config.h"
#include "net/proxy/proxy_info.h"
@@ -667,9 +666,7 @@ TEST_F(DataReductionProxyNetworkDelegateTest, RequestDataConfigurations) {
net::HttpRequestHeaders headers;
net::ProxyRetryInfoMap proxy_retry_info;
- std::map<std::string, std::string> network_quality_estimator_params;
- net::TestNetworkQualityEstimator test_network_quality_estimator(
- network_quality_estimator_params);
+ net::TestNetworkQualityEstimator test_network_quality_estimator;
test_network_quality_estimator.set_effective_connection_type(
net::EFFECTIVE_CONNECTION_TYPE_OFFLINE);
context()->set_network_quality_estimator(&test_network_quality_estimator);
@@ -758,9 +755,7 @@ TEST_F(DataReductionProxyNetworkDelegateTest, RedirectRequestDataCleared) {
net::HttpRequestHeaders headers;
net::ProxyRetryInfoMap proxy_retry_info;
- std::map<std::string, std::string> network_quality_estimator_params;
- net::TestNetworkQualityEstimator test_network_quality_estimator(
- network_quality_estimator_params);
+ net::TestNetworkQualityEstimator test_network_quality_estimator;
test_network_quality_estimator.set_effective_connection_type(
net::EFFECTIVE_CONNECTION_TYPE_OFFLINE);
context()->set_network_quality_estimator(&test_network_quality_estimator);

Powered by Google App Engine
This is Rietveld 408576698