Create compositor animations for effect animations in SPv2.

Create compositor animations for effect animations in SPv2.

Further work needed to complete starting animation cc-side inclusive
of routing start time back to Blink.

Addition of direct compositing reason to EffectPaintProperyNode in this change
is lifted from http://crrev.com/2581843002.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/fbbcd30726ccc750fb8434b0992e7a006b106473
Cr-Commit-Position: refs/heads/master@{#440295}

[wkorman, 2016-12-20 22:28:26]

Description was changed from

==========
Create compositor animations for effect animations in SPv2.

Further work needed to complete starting animation cc-side inclusive
of routing start time back to Blink.

Addition of direct compositing reason to EffectPaintProperyNode in this change
is lifted from http://crrev.com/2581843002.

BUG=674317
==========

to

==========
Create compositor animations for effect animations in SPv2.

Further work needed to complete starting animation cc-side inclusive
of routing start time back to Blink.

Addition of direct compositing reason to EffectPaintProperyNode in this change
is lifted from http://crrev.com/2581843002.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[wkorman, 2016-12-20 22:58:55]

wkorman@chromium.org changed reviewers:
+ pdr@chromium.org

[wkorman, 2016-12-20 22:58:55]

Note dependent patchset to land ahead of this.

[pdr., 2016-12-20 23:34:18]

LGTM except for the lifecycle issue.

https://codereview.chromium.org/2596623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CompositorAnimations.cpp (right):

https://codereview.chromium.org/2596623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CompositorAnimations.cpp:349: if
(RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
I noticed this can be called during style recalc (per the comment in
cancelAnimationOnCompositor). I think we may need another place for this logic
:(

I wonder if that assert is just stale. Could you try just adding a DCHECK that
we're in a good enough lifecycle phase? Something like:
DCHECK(document().lifecycle().state() >= DocumentLifecycle::PrePaintClean);

[wkorman, 2016-12-21 23:12:38]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2016-12-21 23:12:39]

https://codereview.chromium.org/2596623002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CompositorAnimations.cpp (right):

https://codereview.chromium.org/2596623002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CompositorAnimations.cpp:349: if
(RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
On 2016/12/20 at 23:34:18, pdr (OOO Dec 23 to Jan 2) wrote:
> I noticed this can be called during style recalc (per the comment in
cancelAnimationOnCompositor). I think we may need another place for this logic
:(
> 
> I wonder if that assert is just stale. Could you try just adding a DCHECK that
we're in a good enough lifecycle phase? Something like:
> DCHECK(document().lifecycle().state() >= DocumentLifecycle::PrePaintClean);

Good point, updated comment and filed http://crbug.com/676456.

[wkorman, 2016-12-21 23:12:39]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2596623002/#ps40001
(title: "Sync to head and add node removal test.")

[commit-bot: I haz the power, 2016-12-21 23:13:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 01:20:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482361958731210,
"parent_rev": "385602694d9a49b8157ff81e658d77548b89a16b", "commit_rev":
"a067b7cef80c3ba4729ff656d0ccca70035fa23c"}

[commit-bot: I haz the power, 2016-12-22 01:20:45]

Description was changed from

==========
Create compositor animations for effect animations in SPv2.

Further work needed to complete starting animation cc-side inclusive
of routing start time back to Blink.

Addition of direct compositing reason to EffectPaintProperyNode in this change
is lifted from http://crrev.com/2581843002.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Create compositor animations for effect animations in SPv2.

Further work needed to complete starting animation cc-side inclusive
of routing start time back to Blink.

Addition of direct compositing reason to EffectPaintProperyNode in this change
is lifted from http://crrev.com/2581843002.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2596623002
==========

[commit-bot: I haz the power, 2016-12-22 01:20:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-22 01:24:12]

Description was changed from

==========
Create compositor animations for effect animations in SPv2.

Further work needed to complete starting animation cc-side inclusive
of routing start time back to Blink.

Addition of direct compositing reason to EffectPaintProperyNode in this change
is lifted from http://crrev.com/2581843002.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2596623002
==========

to

==========
Create compositor animations for effect animations in SPv2.

Further work needed to complete starting animation cc-side inclusive
of routing start time back to Blink.

Addition of direct compositing reason to EffectPaintProperyNode in this change
is lifted from http://crrev.com/2581843002.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/fbbcd30726ccc750fb8434b0992e7a006b106473
Cr-Commit-Position: refs/heads/master@{#440295}
==========

[commit-bot: I haz the power, 2016-12-22 01:24:14]

Patchset 3 (id:??) landed as
https://crrev.com/fbbcd30726ccc750fb8434b0992e7a006b106473
Cr-Commit-Position: refs/heads/master@{#440295}