Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2596623002: Create compositor animations for effect animations in SPv2. (Closed)
Patch Set: Sync to head and add node removal test. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
index b2f4792cbd2d1d5ef2195439409926d321b9bbe5..8abb550312de91b58dea01611c0a12cc497621ec 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
@@ -468,11 +468,17 @@ void PaintPropertyTreeBuilder::updateEffect(
// We should generate a special clip node to represent this expansion.
}
+ CompositingReasons compositingReasons =
+ CompositingReasonFinder::requiresCompositingForEffectAnimation(
+ object.styleRef());
+ if (compositingReasons != CompositingReasonNone)
+ effectNodeNeeded = true;
+
if (effectNodeNeeded) {
auto& properties = object.getMutableForPainting().ensurePaintProperties();
context.forceSubtreeUpdate |= properties.updateEffect(
context.currentEffect, context.current.transform, outputClip,
- std::move(filter), opacity, blendMode);
+ std::move(filter), opacity, blendMode, compositingReasons);
} else {
if (auto* properties = object.getMutableForPainting().paintProperties())
context.forceSubtreeUpdate |= properties->clearEffect();

Powered by Google App Engine
This is Rietveld 408576698