Create compositor animations for effect animations in SPv2.

third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 328 matching lines @@
          attachedAnimation->affects(targetElement, CSSPropertyBackdropFilter)))
       attachedAnimation->cancelAnimationOnCompositor();
   }
 }
 
 bool CompositorAnimations::canStartAnimationOnCompositor(
     const Element& element) {
   if (!Platform::current()->isThreadedAnimationEnabled())
     return false;
 
   if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {

[pdr., 2016/12/20 23:34:18]

I noticed this can be called during style recalc (per the comment in
cancelAnimationOnCompositor). I think we may need another place for this logic
:(

I wonder if that assert is just stale. Could you try just adding a DCHECK that
we're in a good enough lifecycle phase? Something like:
DCHECK(document().lifecycle().state() >= DocumentLifecycle::PrePaintClean);

[wkorman, 2016/12/21 23:12:39]

Good point, updated comment and filed http://crbug.com/676456.

-    // TODO(wkorman): Consider effect node for opacity.
+    const ObjectPaintProperties* paintProperties =
+        element.layoutObject()->paintProperties();
     const TransformPaintPropertyNode* transformNode =
-        element.layoutObject()->paintProperties()->transform();
-    return transformNode && transformNode->hasDirectCompositingReasons();
+        paintProperties->transform();
+    const EffectPaintPropertyNode* effectNode = paintProperties->effect();
+    return (transformNode && transformNode->hasDirectCompositingReasons()) ||
+           (effectNode && effectNode->hasDirectCompositingReasons());
   }
 
   return element.layoutObject() &&
          element.layoutObject()->compositingState() == PaintsIntoOwnBacking;
 }
 
 void CompositorAnimations::startAnimationOnCompositor(
     const Element& element,
     int group,
     double startTime,
@@ skipping 261 matching lines @@
     animation->setTimeOffset(compositorTiming.scaledTimeOffset);
     animation->setDirection(compositorTiming.direction);
     animation->setPlaybackRate(compositorTiming.playbackRate);
     animation->setFillMode(compositorTiming.fillMode);
     animations.push_back(std::move(animation));
   }
   DCHECK(!animations.isEmpty());
 }
 
 }  // namespace blink